Skip to content

Enable ObjectStore by default on Java 17 and later - #13480

Open
mcculls wants to merge 1 commit into
masterfrom
mcculls/objectstore-java17
Open

mcculls wants to merge 1 commit into
masterfrom
mcculls/objectstore-java17

Conversation

@mcculls

@mcculls mcculls commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Enable shared ObjectStore context storage by default on Java 17 and later, expanding the rollout from Java 25+.

Motivation

Extend the ObjectStore rollout to Java 17–24.

Additional Notes

Explicit map-per-store configuration overrides remain supported.

@mcculls mcculls added type: feature Enhancements and improvements comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM labels Nov 16, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 58.80% (-1.55%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 15ed4aa | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 13.99 s [-0.6%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.98 s 13.00 s [-0.9%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.76 s 17.74 s [-0.7%; +0.9%] (no difference)
startup:petclinic:iast:Agent 17.65 s 17.76 s [-1.4%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 17.50 s 17.21 s [+0.5%; +2.9%] (maybe worse)
startup:petclinic:sca:Agent 17.83 s 17.66 s [+0.2%; +1.8%] (maybe worse)
startup:petclinic:tracing:Agent 16.79 s 16.94 s [-2.3%; +0.5%] (no difference)

Commit: 15ed4aa1 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls
mcculls force-pushed the mcculls/objectstore-java17 branch from 61982bc to 15ed4aa Compare November 16, 2026 23:46
@mcculls
mcculls marked this pull request as ready for review November 16, 2026 23:47
@mcculls
mcculls requested a review from a team as a code owner November 16, 2026 23:47
@mcculls
mcculls requested review from sarahchen6 and removed request for a team November 16, 2026 23:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T23:50:06.189194Z 15ed4aa Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Explicit map-per-store overrides remain effective as shared ObjectStore storage becomes the default on Java 17–24. Defaults below Java 17 remain unchanged.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 15ed4aa

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant