Skip to content

fix(ffe): require explicit boolean allocation doLog - #4346

Draft
leoromanovsky wants to merge 1 commit into
masterfrom
leoromanovsky/dolog-required
Draft

leoromanovsky wants to merge 1 commit into
masterfrom
leoromanovsky/dolog-required

Conversation

@leoromanovsky

Copy link
Copy Markdown
Contributor

Description

Require an explicit JSON boolean for each allocation’s doLog. A missing value must not enable exposure logging. Invalid allocation metadata rejects that flag with PARSE_ERROR; valid neighboring flags remain usable.

Adopt the native parser fix from DataDog/libdatadog#2705 and shared fixtures from DataDog/ffe-system-test-data#51. The fixture runner now checks reasons and declared error codes as well as values. Update the native dependency declarations, lockfile, and generated headers required by that pin.

Test coverage: the PHP 8.1 native extension passes all 321 shared cases, including 14 doLog cases. The feature-flag PHPT suite passes 4 tests; 2 development-environment tests are skipped. Removing only the native parser fix makes two shared cases fail. Full platform CI and packaged system tests remain outstanding.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.39% (-0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2189ee2 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Oct 20, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-10-20 21:28:36

Comparing candidate commit 2189ee2 in PR branch leoromanovsky/dolog-required with baseline commit 77c6cf6 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 2 performance regressions! Performance is the same for 191 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+3.855µs; +4.805µs] or [+3.391%; +4.227%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.995µs; +5.845µs] or [+3.643%; +5.331%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:LaravelBench/benchLaravelDdprof-opcache

  • unstable execution_time [-631.873µs; +1346.833µs] or [-4.339%; +9.249%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant