Repository navigation
Add precomputed dependent flag fixture - #62
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the web-only dependent-flag evaluation and telemetry fixture.
No open issues 🎉
What changed in this PR
Adds a web-only precomputed-assignment fixture for client SDK testing of dependent flag evaluation and telemetry, supporting browser-based RUM enrichment checks.
Changes:
- Defines successful and failed dependency graphs with explicit prerequisite references.
- Checks successful resolution and caller-default fallback with propagated
FLAG_NOT_FOUNDerrors. - Asserts exact exposure and evaluation event counts, excluding exposures for failed or non-selected branches.
| File | Description |
|---|---|
precomputed-assignments/cases/emissions/dependent-flags.json |
Adds dependent flag assignments, expected evaluation results, and telemetry matchers scoped to web. |
Review effort: Balanced
typotter
force-pushed
the
dependent-flags-precomputed-fixtures
branch
from
November 4, 2026 00:55
6225ec3 to
572e59d
Compare
Model ordered dependency telemetry on the expanded corpus and generate plain and obfuscated Web fixtures with encoded dependency references. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
typotter
force-pushed
the
dependent-flags-precomputed-fixtures
branch
from
November 4, 2026 19:26
572e59d to
2930c3f
Compare
hhan2024
approved these changes
Nov 4, 2026
aarsilv
reviewed
Nov 4, 2026
aarsilv
reviewed
Nov 4, 2026
Co-authored-by: tyler.potter <tyler.potter@datadoghq.com>
Generate and validate root-scoped encrypted dependency references while retaining hashed top-level keys in the shared precomputed corpus. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
This was referenced Nov 5, 2026
aarsilv
reviewed
Nov 5, 2026
aarsilv
reviewed
Nov 5, 2026
Return GENERAL for requested roots and intermediate ancestors while preserving the originating dependency's specific error. Enforce the contract in fixture validation and regenerate the obfuscated companion. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Client SDKs need shared precomputed-assignment fixtures for validating dependent flag evaluation, telemetry, RUM enrichment, and response-key obfuscation.
Changes
dependencyEvaluations.FLAG_NOT_FOUND, returns the caller default, and marks an evaluated but non-selected leaf withisPresentInAssignment: false.attributes.flags; put failed roots in siblingattributes.flagEvaluationErrors.Contract
For obfuscated responses, capable clients decrypt each parent key using the caller root flag key, hash the recovered plaintext key for top-level lookup, and use the recovered plaintext key in dependency telemetry. Legacy clients ignore
flagEvaluationErrorsand continue to parse otherwise valid assignments.The fixture remains scoped to
web, where the dependent-assignment client implementation and RUM-FIT coverage are available.Validation
python3 ci/precomputed_obfuscation.py --check: synchronized.python3 ci/validate-precomputed-fixtures.py: 65 valid, 0 errors.python3 -m unittest discover -s ci -p "test_*.py": 67 passed.Checklist
ufc-config.json.