Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the exposure timestamp and unsupported variation-type fixture updates.
No open issues 🎉
What changed in this PR
Corrects two precomputed assignment fixtures to align with browser SDK behavior and FFE requirements.
Changes:
- Adds a response creation timestamp to the serial-ID exposure fixture.
- Changes the unsupported wire variation type expectation to
PARSE_ERROR, leaving valid-type/wrong-getter and exposure assertions unchanged.
| File | Description |
|---|---|
precomputed-assignments/cases/evaluator/defaults-and-emission-gates.json |
Expects PARSE_ERROR for an unsupported variation type. |
precomputed-assignments/cases/emissions/serial-id-on-exposure.json |
Adds createdAt to the mocked response attributes. |
Review effort: Balanced
| | `FLAG_NOT_FOUND` | Flag key not in response, or flag dropped due to malformed data | | ||
| | `TYPE_MISMATCH` | Incompatible getter, fractional/out-of-range Integer read, or rejected Double conversion (see the README numeric rules) | | ||
| | `PARSE_ERROR` | Enumerated field contains an unexpected value. Unsupported `variationType` values are omitted; lookup returns `FLAG_NOT_FOUND`. | | ||
| | `PARSE_ERROR` | Enumerated field contains an unexpected value, including an unsupported `variationType`. Preserve the per-flag parse error; healthy sibling flags remain evaluable. | |
There was a problem hiding this comment.
🤖 Comment from Codex working with @sameerank:
🟡 [P2] Align the remaining malformed-flag guidance with this rule
This row now correctly preserves PARSE_ERROR for an unsupported variationType. However, line 149 still says a flag dropped because of malformed data returns FLAG_NOT_FOUND, and lines 188–190 repeat that malformed flags return FLAG_NOT_FOUND. The root README and CONTRIBUTING.md reserve FLAG_NOT_FOUND for keys absent from both active assignments and rejected-key tracking. Please update these two nearby passages so future fixtures do not reintroduce the old behavior.
Suggested wording
| `FLAG_NOT_FOUND` | Flag key absent from both the active and rejected maps |
For the isolation example, state that malformed flags return defaultValue with PARSE_ERROR, while healthy sibling flags remain evaluable.
Was this finding useful? React with 👍 or 👎.
| { | ||
| "name": "defaults-and-emission-gates", | ||
| "description": "Precomputed assignments that validate exposure gates, unknown variation isolation, and default/error flagevaluation payloads. Unsupported variation types are omitted; lookup returns FLAG_NOT_FOUND.", | ||
| "description": "Precomputed assignments that validate exposure gates, unknown variation isolation, and default/error flagevaluation payloads. Unsupported variation types preserve a per-flag PARSE_ERROR; healthy sibling flags remain evaluable.", |
There was a problem hiding this comment.
🤖 Comment from Codex working with @sameerank:
🔵 [P3] Name the unsupported variation-type case precisely
The updated sentence now documents the correct PARSE_ERROR behavior, but the earlier phrases still say “unknown variation isolation” and “flagevaluation payloads.” This case supplies a known flag with an unsupported wire variationType, and the fixture asserts evaluation results rather than event payload fields. Please use “unsupported variation type isolation” and “flag evaluation results,” then regenerate the obfuscated companion.
Suggested description
Precomputed assignments that validate exposure gates, unsupported variation type isolation, and default/error flag evaluation results. Unsupported variation types preserve a per-flag PARSE_ERROR; healthy sibling flags remain evaluable.
Was this finding useful? React with 👍 or 👎.
sameerank
left a comment
There was a problem hiding this comment.
The documentation finds are non-blocking, but seem worth updating before you merge

Motivation
Two precomputed fixtures fail against the browser SDK because the serial-ID response lacks a creation timestamp and the unsupported-type case expects the wrong error code.
Changes
createdAtto the serial-ID exposure fixture.PARSE_ERRORfor an unsupported wire variation type, following the FFE SDK requirements.Decisions
Keep the valid-type/wrong-getter
TYPE_MISMATCHexpectation and all exposure assertions unchanged.Checklist
config/ufc-config.json— no new casesevaluation-cases/— no new flags