Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The full-range shard in ufc-config.json incorrectly uses SPLIT instead of TARGETING_MATCH, causing the wrong protobuf evaluation reason and requiring correction plus regeneration of the core artifacts and manifest.
1 open issue
What changed in this PR
Adds explicit split reasons to UFC fixtures so protobuf evaluation can report why a value was selected instead of returning UNKNOWN.
Changes:
- Adds 229 reasons across the core, flag-selection, and dependent-flags configurations.
- Regenerates core protobuf and ConfigurationWire artifacts and updates manifest hashes.
- Preserves evaluation expectations, targeting logic, shard ranges, and malformed-input structures.
| File | Description |
|---|---|
ufc-config.json |
Adds reasons to core fixture splits. |
rules-resources/generated/manifest.json |
Updates source and generated artifact hashes. |
rules-resources/generated/canonical-evaluator/configuration-wire.json |
Refreshes the encoded configuration with split reasons. |
evaluation-suites/flag-selection/ufc-config.json |
Adds static reasons to flag-selection fixtures. |
evaluation-suites/dependent-flags/ufc-config.json |
Adds static, targeting, and default reasons to dependency fixtures. |
Review effort: Balanced
| } | ||
| ] | ||
| ], | ||
| "reason": "SPLIT" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
The protobuf evaluator uses the reason supplied on each split. UFC fixtures omit that metadata, so successful evaluations return UNKNOWN. Add explicit reasons to the fixture inputs so protobuf evaluation can report why a value was selected.
Changes
Decisions
Use SPLIT when non-trivial sharding determines the assignment, ahead of TARGETING_MATCH. Treat full-range shards as no splitting when choosing the reason, while preserving their original structure. Use STATIC for unconditional first/only allocations without dates, and DEFAULT for later catch-alls or time-window-only allocations.
Leave two intentionally malformed split objects unannotated. The converter continues to preserve source data without synthesising reasons or normalising fixtures.
Validation: 72 Python tests, nine Node tests, fixture/schema/integrity checks and repeat generation pass. Original JSON evaluation remains unchanged. Offline Chromium lifecycle passes. The core browser corpus reports 309 passed, 46 failed and 20 conversion omissions. The failures comprise 37 reason-expectation mismatches, six existing missing-PARSE_ERROR cases and three unavailable feature-destination observations. Expectations remain unchanged so these differences stay visible. Named suites received static validation; this run does not claim their browser execution.
Checklist
config/ufc-config.json— not applicable; no new casesevaluation-cases/— not applicable; no new flags