chore(libdd-data-pipeline): solve cargo deny [APMSP-3884] - #2318
Open
Eldolfin wants to merge 3 commits into
Open
chore(libdd-data-pipeline): solve cargo deny [APMSP-3884]#2318Eldolfin wants to merge 3 commits into
Eldolfin wants to merge 3 commits into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 83d4d85 | Docs | Datadog PR Page | Give us feedback! |
We cannot update `time` before bumping our MSRV. Also we're not affected by this because there is no user provided input
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
BenchmarksComparisonBenchmark execution time: 2026-08-05 13:23:40 Comparing candidate commit 2021264 in PR branch Found 9 performance improvements and 21 performance regressions! Performance is the same for 110 metrics, 0 unstable metrics.
|
Eldolfin
marked this pull request as ready for review
August 5, 2026 14:58
Contributor
Author
|
@codex review |
brettlangdon
approved these changes
Aug 5, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 202126436a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [[package]] | ||
| name = "rand" | ||
| version = "0.8.5" | ||
| version = "0.8.7" |
There was a problem hiding this comment.
Updating the lockfile to rand 0.8.7 fixes RUSTSEC-2026-0097 only for this workspace checkout; libdd-data-pipeline and the other publishable crates still declare rand = "0.8.5"/"0.8" in their manifests, so consumer lockfiles that already contain 0.8.5 or minimal-version builds can continue using the affected version. Cargo documents that Cargo.lock “does not affect the consumers of your package, only Cargo.toml does” (https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control), and RustSec marks the 0.8 line patched only from 0.8.6 (https://rustsec.org/advisories/RUSTSEC-2026-0097.html); please raise the manifest lower bounds to at least 0.8.6/0.8.7 where rand is a dependency.
Useful? React with 👍 / 👎.
| [[package]] | ||
| name = "rand" | ||
| version = "0.8.5" | ||
| version = "0.8.7" |
There was a problem hiding this comment.
Updating the lockfile to rand 0.8.7 fixes RUSTSEC-2026-0097 only for this workspace checkout; libdd-data-pipeline and the other publishable crates still declare rand = "0.8.5"/"0.8" in their manifests, so consumer lockfiles that already contain 0.8.5 or minimal-version builds can continue using the affected version. Cargo documents that Cargo.lock “does not affect the consumers of your package, only Cargo.toml does that” (https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control), and RustSec marks the 0.8 line patched only from 0.8.6 (https://rustsec.org/advisories/RUSTSEC-2026-0097.html); please raise the manifest lower bounds to at least 0.8.6/0.8.7 where rand is a dependency.
Useful? React with 👍 / 👎.
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Solve
cargo denyerrors inlibdd-data-pipelineby updating some dependencies.Motivation
What inspired you to submit this pull request?
Additional Notes
Sadly, updating
timerequires a bump in our MSRV from1.87.0to1.88.0, this can be done in a separate PR.How to test the change?
Describe here in detail how the change can be validated.