Conversation
Add `pup profiling explore callgraph`, calling the new prof-gateway /api/unstable/profiling/pup/explore/callgraph endpoint (PROF-16038). - explore_callgraph in src/commands/profiling.rs, mirroring explore_flamegraph (query/trace/profile scoping, profile-id+event-id pairing validation) - ProfilingExploreActions::Callgraph clap variant and dispatch in src/main.rs - Tests for happy path, scoping/pairing validation, null optional fields, validation errors, and missing auth - Call graph examples in docs/EXAMPLES.md and command listing in docs/COMMANDS.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The backend's traceContext requires traceId, spanId and timeHint (epoch seconds) together and rejects requests with a null timeHint, so `--trace-id` scoping could never succeed. - Add a shared trace_context_json helper that validates the three flags together and converts --time-hint (any pup time format) to epoch seconds - Add --time-hint to `pup profiling explore callgraph` - Tests for the helper and for the callgraph traceContext request body Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
pup profiling explore callgraph, which calls the Continuous Profiler call graph exploration endpoint (POST /api/unstable/profiling/pup/explore/callgraph) and returns ranked call graph nodes (self/total values and percentages, top outgoing edges) for a query, trace/span, or single profile.src/commands/profiling.rs:explore_callgraph, structured likeexplore_flamegraph. It requires one of--query,--trace-idor--profile-id, requires--profile-id/--event-idtogether, and builds the JSON body.src/main.rs:ProfilingExploreActions::Callgraph(--trace-id/--span-id/--time-hint,--percent-cutoff,--limit-top-nodes,--max-node-details,--frame-filterglob) plus dispatch.docs/EXAMPLES.mdand the command listing indocs/COMMANDS.md.Motivation
Follow-up to #819 (
pup profilingoperations). Call graph exploration was deferred from that MVP. The backend (prof-viz-java) and gateway (prof-gateway) sides are now merged and deployed.Additional Notes
continuous_profiler_readscope (same as flamegraph), so there are no new scopes or dependencies.--frame-filteris an anchored glob matched against frame fields server-side, e.g.*MyService*.--trace-idscoping requires--span-idand--time-hint(any pup time format, sent as epoch seconds): the backend rejects a trace context without atimeHint. The sharedtrace_context_jsonhelper is reused by timeline exploration (feat(profiling): add continuous profiler timeline exploration #877).Checklist
Related Issues
Follow-up to #819.
Plan
Prompts
🤖 Generated with Claude Code