Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/auth/tokenScopes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export function isScopedTokenRequestAllowed(
return allowsRead(scopes, 'templates:write', 'cards:write', 'newsletter:write');
}

if (isRead && (matchesPrefix(path, '/api/academy-leads') || matchesPrefix(path, '/api/academy-pageviews'))) {
if (isRead && matchesPrefix(path, '/api/academy-pageviews')) {
return allowsRead(scopes, 'cards:write', 'newsletter:write');
}

Expand Down
1 change: 0 additions & 1 deletion backend/src/docs/frontend-assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@
"src/surfaces/finance/sponsors.js",
"src/surfaces/finance/tuition.js",
"src/surfaces/inbox.js",
"src/surfaces/academy-leads.js",
"src/surfaces/knowledge/catalog.js",
"src/surfaces/knowledge/filters.js",
"src/surfaces/knowledge/index.js",
Expand Down
5 changes: 0 additions & 5 deletions backend/src/router.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { handleTuitionRoutes } from './routes/tuition';
import { handleAcademyLeadsRoutes } from './routes/academyLeads';
import { handleAcademyPageviewsRoutes } from './routes/academyPageviews';
import { timingSafeEqual } from 'crypto';
import { portalRuntimeSecret } from './runtimeSecret';
Expand Down Expand Up @@ -375,10 +374,6 @@ async function route(event: LambdaEvent, client: DynamoDBDocumentClient): Promis
return await handleReconcileRoutes(reqPath, method, event, client);
}
if (reqPath === '/api/tuition' || reqPath.startsWith('/api/tuition/')) return await handleTuitionRoutes(reqPath, method, event, client);
if (reqPath === '/api/academy-leads') {
const academy = await handleAcademyLeadsRoutes(reqPath, method, event);
if (academy) return academy;
}
if (reqPath === '/api/academy-pageviews') {
const pageviews = await handleAcademyPageviewsRoutes(reqPath, method, event);
if (pageviews) return pageviews;
Expand Down
19 changes: 0 additions & 19 deletions backend/src/routes/academyLeads.ts

This file was deleted.

2 changes: 0 additions & 2 deletions cli/src/cli.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import * as sponsors from "./commands/sponsors.mjs";
import * as sponsorDocs from "./commands/sponsorDocs.mjs";
import * as crm from "./commands/crm.mjs";
import * as vies from "./commands/vies.mjs";
import * as academyLeads from "./commands/academyLeads.mjs";
import * as academyPageviews from "./commands/academyPageviews.mjs";
import * as tasks from "./commands/tasks.mjs";
import * as templates from "./commands/templates.mjs";
Expand Down Expand Up @@ -80,7 +79,6 @@ export const FAMILIES = {
"text-templates": { group: "Work", summary: textTemplates.summary, help: textTemplates.help, commands: textTemplates.commands },
email: { group: "Work", summary: email.summary, help: email.help, commands: email.commands },
"academy-pageviews": { group: "Planning", summary: academyPageviews.summary, help: academyPageviews.help, run: academyPageviews.run },
"academy-leads": { group: "Planning", summary: academyLeads.summary, help: academyLeads.help, run: academyLeads.run },
resources: { group: "Work", summary: resources.summary, help: resources.help, commands: resources.commands },
recurring: {
group: "Work",
Expand Down
102 changes: 0 additions & 102 deletions cli/src/commands/academyLeads.mjs

This file was deleted.

1 change: 0 additions & 1 deletion frontend/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
<a id="sponsors-nav-button" class="dk-nav-item workspace-nav-button" href="/sponsors" data-workspace-view="sponsors"><span class="dk-nav-item__icon" aria-hidden="true"><svg viewBox="0 0 24 24"><circle cx="9" cy="8" r="3"/><circle cx="17" cy="9" r="2"/><path d="M3 20c0-4 2-6 6-6s6 2 6 6m1-6c3 0 5 2 5 5"/></svg></span><span class="dk-nav-item__label">CRM</span></a>
<a id="finance-nav-button" class="dk-nav-item workspace-nav-button" href="/finance" data-workspace-view="finance"><span class="dk-nav-item__icon" aria-hidden="true"><svg viewBox="0 0 24 24"><path d="M4 20h16"/><path d="M7 16v-5M12 16V6M17 16v-8"/></svg></span><span class="dk-nav-item__label">Finance</span></a>
<a id="bookkeeping-nav-button" class="dk-nav-item workspace-nav-button" href="/bookkeeping" data-workspace-view="bookkeeping"><span class="dk-nav-item__icon" aria-hidden="true"><svg viewBox="0 0 24 24"><path d="M5 3h14v18H5Z"/><path d="M8 7h8M8 11h8M8 15h3M15 15h1M8 18h3M15 18h1"/></svg></span><span class="dk-nav-item__label">Bookkeeping</span></a>
<a id="academy-leads-nav-button" class="dk-nav-item workspace-nav-button" href="/academy-leads" data-workspace-view="academy-leads"><span class="dk-nav-item__icon" aria-hidden="true"><svg viewBox="0 0 24 24"><path d="M12 3 2 8l10 5 10-5-10-5Z"/><path d="M6 10.5v5.5c0 1.7 2.7 3 6 3s6-1.3 6-3v-5.5"/></svg></span><span class="dk-nav-item__label">Academy Leads</span></a>
</div><div class="dk-nav-group"><h2 class="dk-nav-group__label">Knowledge</h2>
<a class="dk-nav-item workspace-nav-button" href="/operating-model" data-workspace-view="operating-model"><span class="dk-nav-item__icon" aria-hidden="true"><svg viewBox="0 0 24 24"><circle cx="12" cy="5" r="2"/><circle cx="6" cy="18" r="2"/><circle cx="18" cy="18" r="2"/><path d="M12 7v4M6 16v-3h12v3"/></svg></span><span class="dk-nav-item__label">Operating Model</span></a>
<a id="docs-nav-button" class="dk-nav-item workspace-nav-button" href="/processes" data-workspace-view="docs"><span class="dk-nav-item__icon" aria-hidden="true"><svg viewBox="0 0 24 24"><path d="M6 3h9l4 4v14H6Z"/><path d="M14 3v5h5M9 12h7M9 16h7"/></svg></span><span class="dk-nav-item__label">Process Docs</span></a>
Expand Down
1 change: 0 additions & 1 deletion frontend/src/core/workspace.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export const WORKSPACE_ROUTE_DEFINITIONS = Object.freeze({
"/newsletter/:issueId": { view: "newsletter", tasksSection: "queue", params: [] },
"/calendar": { view: "calendar", tasksSection: "queue", params: [] },
"/inbox": { view: "inbox", tasksSection: "queue", params: ["status", "item"] },
"/academy-leads": { view: "academy-leads", tasksSection: "queue", params: ["includeTests", "track"] },
// ?view=list swaps the seasons overview for the plain episode list.
"/podcast": { view: "podcast", tasksSection: "queue", params: ["view"] },
"/podcast/schedule": { view: "podcast", tasksSection: "queue", params: [] },
Expand Down
11 changes: 0 additions & 11 deletions frontend/src/runtime/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import { createKnowledgeSurface } from "../surfaces/knowledge/index.js";
import { createDocumentEditor } from "../surfaces/document-editor/index.js";
import { createPodcastSurface } from "../surfaces/podcast/index.js";
import { createInboxSurface } from "../surfaces/inbox.js";
import { createAcademyLeadsSurface } from "../surfaces/academy-leads.js";
import { createOperatingModelSurface } from "../surfaces/operating-model.js";
import { createApiClient, resolveApiBase } from "../shell/api.js";
import { createFeedbackShell } from "../shell/feedback.js";
Expand Down Expand Up @@ -159,7 +158,6 @@ const {
getKnowledgeSelectedFolder: () => knowledgeState.selectedFolder,
getNormalizeOperationsRecurringSnapshot: () =>
normalizeOperationsRecurringSnapshot,
getRenderAcademyLeadsSurface: () => academyLeadsSurface?.renderAcademyLeads || (() => undefined),
getRenderAdminSurfaceView: () => renderAdminSurfaceView,
getRenderBookkeepingSurface: () => renderBookkeepingSurface,
getRenderFinanceOverviewSurface: () => renderFinanceOverviewSurface,
Expand Down Expand Up @@ -600,15 +598,6 @@ inboxSurface = createInboxSurface({
workApiUrl,
});

const academyLeadsSurface = createAcademyLeadsSurface({
documentList,
getActiveWorkspaceRoute,
navigateCanonicalWorkspace,
request,
setRouteTitle,
workApiUrl,
});

knowledgeSurface = createKnowledgeSurface({
knowledgeTools: document.querySelector("#knowledge-tools"),
renderInBackground,
Expand Down
2 changes: 0 additions & 2 deletions frontend/src/runtime/surface-composition.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ export function createSurfaceComposition(context) {
getCanLeaveDocumentEditor,
getCanLeaveFinanceSurface,
getKnowledgeSelectedFolder,
getRenderAcademyLeadsSurface,
getRenderAdminSurfaceView,
getRenderBookkeepingSurface,
getRenderFinanceOverviewSurface,
Expand Down Expand Up @@ -167,7 +166,6 @@ export function createSurfaceComposition(context) {
if (view === "newsletter") return getRenderNewsletterSurface()();
if (view === "calendar") return getRenderCalendarSurface()();
if (view === "inbox") return getRenderInboxSurface()();
if (view === "academy-leads") return getRenderAcademyLeadsSurface()();
if (view === "podcast") return getRenderPodcastSurface()();
return getRenderTasksSurface()(documents, "queue");
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/shell/startup-orchestration.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// deferred at bootstrap and shielded from snapshot repaints together, so the
// two can never drift apart.
export const SELF_LOADING_VIEWS = Object.freeze(
new Set(["academy-leads", "bookkeeping", "calendar", "finance", "inbox", "newsletter", "podcast", "sponsors", "users"]),
new Set(["bookkeeping", "calendar", "finance", "inbox", "newsletter", "podcast", "sponsors", "users"]),
);

// Whether committing this route needs none of the shared snapshots yet. An
Expand Down
Loading