Repository navigation
Render event covers from the Figma frames; remove hand-made podcast layout - #476
Merged
Merged
Conversation
…vent), drop the hand-made podcast layout The 13-14 Nov podcast cover came from backend/src/banners/podcastLayout.ts, a hand-written flow layout that added a date line and the DataTalks.Club logo that the Figma design (node 3613:146) does not have. The bundle now takes every cover that has a Figma frame from Banner Generator at a pinned commit; composeBanner only fits the Card text into the frame's slots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the cover mismatch: the new podcast cover (date line, DTC logo, different sizes) came from
podcastLayout.ts(2e11622, 13 Nov), not from Figma.dtc-event, pinned ininfra/banner-generator-revision= b466d5aa, PR Add Figma event-banner templates (dtc-event) AI-Shipping-Labs/banner-generator#10) for podcast/webinar/workshop, square+landscape, 1-2 speakers (+sponsored); other combos keep the current templates.composeBannerfits title/names/label into the frame slots (figmaCover.ts); no date line, no logo unless the frame draws one.podcastLayout.tsand its e2e; docs updated.