Repository navigation
cli: fix newsletter final-render 'rewritePreviewUrls is not defined' - #481
Merged
Merged
Conversation
…nd show the final render final-render called an undefined rewritePreviewUrls helper, so every run failed with 'rewritePreviewUrls is not defined'. Use the existing normalizeMarkdownPayloadUrls. --html-file also referenced an unimported fs namespace. newsletter show now prints the stored Final render web view, subject and preview. Intake 9ca2e415-12bf-45b0-a916-86cc5e64342f
The calendar slots tests use fixed 2026-11-16..24 fixtures and the CLI drops dates before today, so they started failing on 2026-11-18. calendar.mjs now uses berlinToday() (which honours DATAOPS_TODAY) and the test pins the date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataops newsletter final-renderfailed on every call witherror: rewritePreviewUrls is not defined: the command called a helper that does not exist. It now uses the existingnormalizeMarkdownPayloadUrls.Also fixed:
--html-filereferenced an unimportedfsnamespace and would also have crashed.dataops newsletter shownow prints the stored final render (web view URL, Relay key, subject, preview, html snapshot size, last update).Tests:
cli/test/newsletter-final-render.test.mjscovers the exact Weekly #303 command,--html-file,--clear, the usage error, and theshowoutput.Intake 9ca2e415-12bf-45b0-a916-86cc5e64342f