Repository navigation
inventory: make Inventory a standalone top-level surface separate from Bookkeeping - #482
Merged
Merged
Conversation
…m Bookkeeping /invertory resolved to a bookkeeping sub-view, so the sidebar lit both Bookkeeping and Inventory at once and Inventory read as a child of the ledger. Inventory is now its own workspace view and surface: the route maps /invertory to view 'inventory', the nav button targets that view, and a new inventory surface fetches the items and renders the original ledger record in its own dialog without mounting bookkeeping. The bookkeeping surface drops the inventory section, its SECONDARY_VIEWS entry, and the sidebar nav ownership; the deployed-asset manifest registers the new module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking Inventory in the sidebar highlighted both Bookkeeping and Inventory (screenshot reported by the user), because
/invertorywas still routed toview: "bookkeeping"and Inventory was a hidden secondary section inside the bookkeeping surface, with its nav entry patched in viadata-bookkeeping-viewspecial cases.Fix
Inventory becomes a genuinely separate top-level surface:
/invertorymaps to its owninventoryview (WORKSPACE_ROUTE_DEFINITIONS,WORKSPACE_PATH_BY_VIEW), and joinsSELF_LOADING_VIEWS.data-workspace-view="inventory"; the generic nav pass lights exactly one entry. Alldata-bookkeeping-viewspecial-casing (nav sync skip, click-path override, bookkeeping's own nav pass) is deleted.frontend/src/surfaces/finance/inventory.jssurface fetches the items and owns a record dialog that fetches the original ledger transaction (GET /transactions/:id) plus documents/links, reusingcreateBookkeepingTransactionModal— provenance (vendor, date, price, VAT, invoice links) works without mounting bookkeeping.SECONDARY_VIEWSentry, and inventory wiring.src/surfaces/finance/inventory.jsis registered in the deployed-asset manifest (backend/src/docs/frontend-assets.json), which the backend requires to serve/src/**files.Verification
/invertorywith h1 "Inventory" and only Inventory highlighted; row click → record dialog with the original transaction; deep link renders standalone; back to Bookkeeping → only Bookkeeping highlighted, ledger renders.ALL FLOWS PASS(evidence in.tmp/inv-live-check-probe/).