Repository navigation
Conversation
On 32-bit platforms size_t is 32 bits: escape_characters += 5 wraps past ~858M control characters, and the length sums can wrap too, so ensure() hands out a small buffer while the write loop emits the true (giant) escaped length -- heap overflow, reachable via cJSON_PrintBuffered with a pre-allocated buffer. Fail instead of wrapping at each accumulation step and before sizing the allocation. Add an escape-heavy exactness regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32-bit platforms size_t is 32 bits: escape_characters += 5 wraps past ~858M control characters (5 * 858993460 = 2^32 + 4), and the length sums can wrap too, so ensure() is asked for a small buffer while the write loop emits the true escaped length -- heap overflow, reachable via cJSON_PrintBuffered with a pre-allocated buffer.
This fails instead of wrapping at each accumulation step and before sizing the allocation, using (size_t)-1 so no new headers are needed. On 64-bit the guards are inert (verified: full suite green, escape-heavy output byte-exact).
Evidence: