Skip to content

Feature/upgrade deepbook to v4 - #142

Merged
avernikoz merged 2 commits into
mainfrom
feature/upgrade-deepbook-to-v4
Nov 9, 2026
Merged

avernikoz merged 2 commits into
mainfrom
feature/upgrade-deepbook-to-v4

Conversation

@bathord

@bathord bathord commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Problem / goal

Move deeptrade-core onto DeepBook v4.

Approach

Pin production deepbook to MystenLabs v4.0.0 and the test swap to our v4-tag-fork-test-methods fork (still required for DeepBook test-only helpers). Point token at MystenLabs main for both production and tests, and drop the DeeptradeProtocol token test pin plus the CI perl that commented/uncommented it.

We kept a DeepBook test fork because tests still need methods that are not on the published v4 package. We did not keep a token test fork: that package is the same for prod and tests, so swapping it in CI would comment out the only remaining pin and leave tests with no token dependency.

Caveat: token is now a moving main pin, not a tagged release. That is intentional (no v4 token tag in use), but the resolved revision can change between lockfile refreshes.

Risk & blast radius

Dependency-only change: no Move sources. Blast radius is compile/runtime compatibility with DeepBook v4 (order, swap, fee, pool paths that call into DeepBook) and test CI’s Move.toml rewrite. Rollback is reverting the two pins and restoring the token CI swap.

How to verify

  • Production build: sui move build --lint --path packages/deeptrade-core with the committed (unswapped) Move.toml
  • Tests: comment production deepbook / pyth, uncomment the v4 DeepBook test fork, leave token as MystenLabs main, then sui move test --lint --path packages/deeptrade-core
  • Confirm Move Test CI still swaps only deepbook and pyth, and that token stays uncommented in the “Move.toml after changes” log
  • Confirm Move.lock is committed if this branch refreshed the token / deepbook revisions (working tree currently has an unstaged Move.lock)

@avernikoz
avernikoz changed the base branch from feature/rebates-claimer-cap to main October 15, 2026 07:06
@avernikoz
avernikoz added this pull request to stack #148 November 9, 2026 08:07
Update deepbook package for tests to use v4-tag-fork-test-methods branch.
@bathord
bathord force-pushed the feature/upgrade-deepbook-to-v4 branch from ab929fc to be7150f Compare November 9, 2026 08:12
@avernikoz
avernikoz merged commit 8012baf into main Nov 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants