Repository navigation
Feature/upgrade deepbook to v4 - #142
Merged
Merged
Conversation
avernikoz
approved these changes
Nov 9, 2026
Update deepbook package for tests to use v4-tag-fork-test-methods branch.
bathord
force-pushed
the
feature/upgrade-deepbook-to-v4
branch
from
November 9, 2026 08:12
ab929fc to
be7150f
Compare
avernikoz
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / goal
Move
deeptrade-coreonto DeepBook v4.Approach
Pin production
deepbookto MystenLabsv4.0.0and the test swap to ourv4-tag-fork-test-methodsfork (still required for DeepBook test-only helpers). Pointtokenat MystenLabsmainfor both production and tests, and drop the DeeptradeProtocoltokentest pin plus the CI perl that commented/uncommented it.We kept a DeepBook test fork because tests still need methods that are not on the published v4 package. We did not keep a
tokentest fork: that package is the same for prod and tests, so swapping it in CI would comment out the only remaining pin and leave tests with notokendependency.Caveat:
tokenis now a movingmainpin, not a tagged release. That is intentional (no v4 token tag in use), but the resolved revision can change between lockfile refreshes.Risk & blast radius
Dependency-only change: no Move sources. Blast radius is compile/runtime compatibility with DeepBook v4 (order, swap, fee, pool paths that call into DeepBook) and test CI’s Move.toml rewrite. Rollback is reverting the two pins and restoring the token CI swap.
How to verify
sui move build --lint --path packages/deeptrade-corewith the committed (unswapped)Move.tomldeepbook/pyth, uncomment the v4 DeepBook test fork, leavetokenas MystenLabsmain, thensui move test --lint --path packages/deeptrade-coredeepbookandpyth, and thattokenstays uncommented in the “Move.toml after changes” logMove.lockis committed if this branch refreshed thetoken/deepbookrevisions (working tree currently has an unstagedMove.lock)