fix(docx): cut a composed chip's centred label to its outline - #796
Merged
Merged
Conversation
…hip taller than its label stays the page's height
…itten margins leave
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #795,
CobaltRotastill ran onto a second page in Word. Its last staff row overflowed.What changed
cutTheLabelToItsOutline, called inwritePanelPiecefor a one-piece panel before its children are written. It applies to a shape composed in a table cell (no layout placement) whose layers are one paragraph of one line, without vertical margin or padding, plus drawings.CENTER,CENTER_LEFTorCENTER_RIGHT, with no vertical offset. A label set from an edge overflows on one side only.DocxStackedLines.Line.DocxStackedLines.INK_MARGIN.CHANGELOG.md, the composed-shape paragraph ofdocs/recipes/docx-export.mdand the composed-panel sentence of the capability matrix are updated.Verification
./mvnw -B -ntp clean verify -pl :graph-compose-core,:graph-compose-render-pdf,:graph-compose-render-docx,:graph-compose-render-pptx,:graph-compose-templates,:graph-compose-testing,:graph-compose-qa,:graph-compose-coverage -amgives BUILD SUCCESS (1791 + 127 tests).extract-api --checkpass.DocxComposedCellTest:2.5-dev: onlyCobaltRotachanges.Known limits
CobaltRota's masthead. Its subtitle's -6.5pt top margin inside a composed cell has no space above it to come out of, which leaves everything under it about 7pt low. Its own change.Lane: shared-engine (render-docx). No public API change.