ci: hold every template's DOCX export to its corpus baseline on Linux - #807
Merged
Merged
Conversation
… with LibreOffice
…nd cache LibreOffice's packages a week at a time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The DOCX fidelity corpus (#805) only runs when someone asks for it on a machine with LibreOffice. A change that sets a template's lines further from the page still merges green.
What changed
docx-fidelityjob inci.yml("DOCX Fidelity (LibreOffice)").ubuntu-24.04image and installs the modules the corpus exports through.DocxFidelityCorpusTestwith-Dgraphcompose.docxFidelity=libreoffice, and uploads what it measured with LibreOffice's log, kept for 7 days.docxpath filter matches: the engine, render-pdf (its font metrics), render-docx, templates, fonts, emoji, the corpus classes and baselines, the build files, and this workflow. Every push and dispatch runs it.CI Gate'sneeds, so a failure fails the aggregate check (CiGateCoverageGuardTestholds that).libreoffice-linux.tsv/-lines.tsv: the Linux baseline, taken from this job's first run (LibreOffice 24.2.7), since LibreOffice on Linux sets text a little differently from Windows. It holds 4,156 of the corpus's 4,328 lines. As in the Windows baseline,OrangeOpsandVioletGridare set on 2 pages.LibreOfficeConverter.build()resolvessofficeto the real file before reading itsversionrc. On Linux/usr/bin/sofficeis a link, and the baseline's note readunknown.CONTRIBUTING.mdsays where each platform's baseline comes from.CHANGELOG.mdhas a Tests entry.Verification
CiGateCoverageGuardTest,CiGateCoverageGuardParsingTest,CiGuardListGuardTest,CodeQlScopeGuardTestandBinaryCompatibilityGateGuardTestpass (24 tests)../mvnw -B -ntp clean verify -pl :graph-compose-core,:graph-compose-render-pdf,:graph-compose-render-docx,:graph-compose-render-pptx,:graph-compose-templates,:graph-compose-testing,:graph-compose-qa,:graph-compose-coverage -amgives BUILD SUCCESS (qa 1809).Tests run: 2, Failures: 0, 33s), with every other job andCI Gategreen.Lane: build/CI.