test(qa): report which presets each editor sets as the page does - #809
Merged
Merged
Conversation
… what keeps the rest short
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The DOCX fidelity baselines hold each preset where it stands, however far that is from the page. Nothing says which presets are already set as the page sets them and which are not, or what keeps the rest short. That is the list the remaining DOCX work is taken from.
What changed
FidelityAcceptancereports where each preset stands. It does not gate; the baselines gate. A preset passes when the editor:DocxFidelityCorpusTestwrites the report beside each measurement astarget/docx-fidelity/measured-<editor>-acceptance.md. It gives the number passing, then each preset short of it, with what keeps it short, the furthest first.ci.yml: theDOCX Fidelityjob appends LibreOffice's report to the job summary, and uploads it with the measurements.CONTRIBUTING.md(testing expectations);CHANGELOG.mdunder Tests.Verification
DocxFidelityGateTest(20 tests, +2).CobaltRota(median 2.48pt),OrangeOps(2 pages),SlateOrange,MidnightNavy,EditorialandMonogramSidebar.CiGate*,CiGuardListGuardTest,CodeQlScopeGuardTest) pass../mvnw -B -ntp clean verify -pl :graph-compose-core,:graph-compose-render-pdf,:graph-compose-render-docx,:graph-compose-render-pptx,:graph-compose-templates,:graph-compose-testing,:graph-compose-qa,:graph-compose-coverage -amgives BUILD SUCCESS (qa 1813).Known limits
Lane: test (qa) and CI.