PivotGrid: Add aria-colindex / aria-rowindex to cells#34178
Merged
Conversation
sjbur
commented
Jun 30, 2026
|
|
||
| if (isDefined(cell.wordWrapEnabled)) { | ||
| span.style.whiteSpace = cell.wordWrapEnabled ? 'normal' : 'nowrap'; | ||
| if (isDefined(cell.wordWrapEnabled)) { |
Contributor
Author
There was a problem hiding this comment.
moved isDefined(cell.wordWrapEnabled) inside if (cell) check because if cell is undefined, we get type error in runtime
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ARIA positional indexing to PivotGrid cells to improve accessibility tooling support, including correct indexing behavior under virtual scrolling.
Changes:
- Add
aria-colindex/aria-rowindexassignment during PivotGrid area cell rendering. - Expose virtual scrolling index offsets via new
DataControllerhelpers. - Add QUnit coverage for basic indexing, multi-level headers with
colspan, and virtual scrolling offsets.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.markup.tests.js | Adds QUnit tests validating aria-colindex/aria-rowindex on header/data areas, including virtual scrolling offsets and colspan behavior. |
| packages/devextreme/js/__internal/grids/pivot_grid/data_controller/m_data_controller.ts | Adds index-offset helpers derived from virtual scroll controllers (beginPageIndex * pageSize). |
| packages/devextreme/js/__internal/grids/pivot_grid/area_item/m_area_item.ts | Sets aria-colindex/aria-rowindex on rendered cells (with a map for multi-level column headers). |
Comment on lines
191
to
+198
| tableElement.data('area', this._getAreaName()); | ||
| tableElement.data('data', data); | ||
| tableElement.css('width', ''); | ||
|
|
||
| const tbody = this._getMainElementMarkup(); | ||
| const areaName = this._getAreaName(); | ||
| const columnIndexOffset = this._getColumnIndexOffset(); | ||
| const rowIndexOffset = this._getRowIndexOffset(); |
aleksei-semikozov
approved these changes
Jul 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.