T1331089 - DateBox: Masked input works incorrectly after refocusing the editor with Tab when Microsoft Bopomofo IME is in Chinese Mode#34191
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves DateBox masked-input behavior when using Microsoft IMEs (notably Windows Bopomofo / Chinese MS IME) by preserving the correct active date part across IME composition, refocus, and composition backspace scenarios, and adds regression tests to cover these cases.
Changes:
- Updated
DateBoxMaskIME handling to remember “all-selected before composition” state and to treatdeleteContentBackward/Forwardduring composition by reverting the active part instead of incorrectly resetting/clearing. - Added new DateBox mask tests covering IME composition selection quirks and composition backspace behavior (T1331089).
- Tightened
_focusInHandlerevent typings in internal TextEditor/TagBox code to useDxEvent<FocusEvent>.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.mask.tests.js | Adds regression tests for IME composition selection/backspace scenarios affecting DateBox mask behavior. |
| packages/devextreme/js/__internal/ui/text_box/text_editor.base.ts | Updates _focusInHandler typing to use DxEvent<FocusEvent>. |
| packages/devextreme/js/__internal/ui/tag_box.ts | Updates _focusInHandler typing to use DxEvent<FocusEvent>. |
| packages/devextreme/js/__internal/ui/date_box/date_box.mask.ts | Implements IME-specific selection/backspace handling improvements for masked DateBox input. |
pharret31
approved these changes
Jul 2, 2026
This was referenced Jul 2, 2026
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Jul 3, 2026
…he editor with Tab when Microsoft Bopomofo IME is in Chinese Mode (DevExpress#34191)
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Jul 3, 2026
…he editor with Tab when Microsoft Bopomofo IME is in Chinese Mode (DevExpress#34191) Co-authored-by: Ruslan Farkhutdinov <ruslan.farkhutdinov@devexpress.com> Co-authored-by: Ruslan Farkhutdinov <rrafarkhutdinov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.