Skip to content

Charts - Stock demo improvements - #35726

Open
16adianay wants to merge 6 commits into
mainfrom
feature/demo-charts-stock-improvements
Open

16adianay wants to merge 6 commits into
mainfrom
feature/demo-charts-stock-improvements

Conversation

@16adianay

Copy link
Copy Markdown
Contributor

No description provided.

@16adianay
16adianay requested review from a team as code owners October 15, 2026 19:04
@16adianay 16adianay changed the title Chart - Stock demo improvements Charts - Stock demo improvements Oct 16, 2026

@EugeniyKiyashko EugeniyKiyashko left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • apps/demos/menuMeta.json is not updated. The Stock entry still has "MvcAdditionalFiles": ["/Models/SampleData/FinancialData.cs"], but after DevExpress/dxvcs#52233 the ASP.NET demo takes its data from StockChartData.cs, so the source viewer will show the wrong file. Please point it to /Models/SampleData/StockChartData.cs (the same way it is done for StochasticData.cs and CustomLegendMarkersSampleData.cs). The Equivalents keywords still list workdaysOnly - consider adding zoomAndPan, scrollBar, visualRange.
  • description.md is not updated. It still says that you can enable argumentAxis.workdaysOnly, and it does not mention the new zoom/pan, scroll bar and visual range API.
  • Unrelated files in the diff. The two Scheduler recurrence-form__*_mask.png etalons are the same blobs that are already in main (#35687), so the squash will not change them, but merging main into the feature branch will remove this noise from the diff.

Minor:

  • The initial visual range (Apr 15 - Apr 29) ends exactly on candle dates, so the first and the last candles are cut in half (visible in the new etalons). Padding the range by half a day on each side would fix it.
  • Mouse wheel and drag zoom are not limited to 3 days the way the buttons are. argumentAxis.minVisualRangeLength: { day: 3 } would make both behave the same.

Comment thread apps/demos/Demos/Charts/Stock/React/App.tsx
Comment thread apps/demos/Demos/Charts/Stock/ReactJs/App.js Outdated
Comment thread apps/demos/Demos/Charts/Stock/jQuery/index.js Outdated
Comment thread apps/demos/Demos/Charts/Stock/Vue/App.vue
Comment thread apps/demos/Demos/Charts/Stock/React/App.tsx Outdated
Comment thread apps/demos/Demos/Charts/Stock/jQuery/index.js
Comment thread apps/demos/Demos/Charts/Stock/jQuery/index.js Outdated
Comment thread apps/demos/Demos/Charts/Stock/jQuery/index.js Outdated
Comment thread apps/demos/Demos/Charts/Stock/Vue/App.vue Outdated
Comment thread apps/demos/Demos/Charts/Stock/description.md Outdated
Comment thread apps/demos/Demos/Charts/Stock/React/App.tsx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants