Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
apps/demos/menuMeta.jsonis not updated. The Stock entry still has"MvcAdditionalFiles": ["/Models/SampleData/FinancialData.cs"], but after DevExpress/dxvcs#52233 the ASP.NET demo takes its data fromStockChartData.cs, so the source viewer will show the wrong file. Please point it to/Models/SampleData/StockChartData.cs(the same way it is done forStochasticData.csandCustomLegendMarkersSampleData.cs). TheEquivalentskeywords still listworkdaysOnly- consider addingzoomAndPan, scrollBar, visualRange.description.mdis not updated. It still says that you can enableargumentAxis.workdaysOnly, and it does not mention the new zoom/pan, scroll bar and visual range API.- Unrelated files in the diff. The two Scheduler
recurrence-form__*_mask.pngetalons are the same blobs that are already in main (#35687), so the squash will not change them, but merging main into the feature branch will remove this noise from the diff.
Minor:
- The initial visual range (Apr 15 - Apr 29) ends exactly on candle dates, so the first and the last candles are cut in half (visible in the new etalons). Padding the range by half a day on each side would fix it.
- Mouse wheel and drag zoom are not limited to 3 days the way the buttons are.
argumentAxis.minVisualRangeLength: { day: 3 }would make both behave the same.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.