Repository navigation
Scheduler: type the m_ files ahead of the rename, part 2 - #35838
Merged
pharret31 merged 6 commits intoOct 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-module type changes and suppressions still need compiler and Scheduler integration validation before approval.
No open issues 🎉
What changed in this PR
Strengthens DevExtreme Scheduler’s internal types ahead of renaming the remaining m_ files.
Changes:
- Types appointment rendering, collections, dragging, and Scheduler callbacks.
- Aligns shared date, geometry, and resizing types.
- Removes the old text utility and modernizes the collector test mock.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.appointmentCollector.tests.js | Converts the mock to class inheritance. |
| packages/devextreme/js/__internal/ui/resizable/resizable.ts | Allows numeric resize steps. |
| packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts | Types Scheduler and drag configuration. |
| packages/devextreme/js/__internal/scheduler/view_model/types.ts | Narrows appointment orientation. |
| packages/devextreme/js/__internal/scheduler/view_model/m_appointment_data_source.ts | Adjusts lint suppressions. |
| packages/devextreme/js/__internal/scheduler/utils_time_zone.ts | Allows numeric timestamps. |
| packages/devextreme/js/__internal/scheduler/types.ts | Refines collector click callbacks. |
| packages/devextreme/js/__internal/scheduler/tooltip_strategies/tooltip_strategy_base.ts | Uses the shared date-format type. |
| packages/devextreme/js/__internal/scheduler/scheduler.ts | Aligns workspace and event contracts. |
| packages/devextreme/js/__internal/scheduler/m_subscribes.ts | Types callback context and removes an unused subscription. |
| packages/devextreme/js/__internal/scheduler/m_compact_appointments_helper.ts | Types collectors, templates, and tooltip events. |
| packages/devextreme/js/__internal/scheduler/m_appointment_drag_behavior.ts | Types drag state and handlers. |
| packages/devextreme/js/__internal/scheduler/appointments/m_text_utils.ts | Removes the old date-text utility. |
| packages/devextreme/js/__internal/scheduler/appointments/m_appointments_kbn.ts | Documents type suppressions. |
| packages/devextreme/js/__internal/scheduler/appointments/m_appointment_layout.ts | Types layout inputs and output. |
| packages/devextreme/js/__internal/scheduler/appointments/m_appointment_collection.ts | Types collection options, events, and resizing. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/m_types.ts | Defines appointment geometry and properties. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/m_appointment.ts | Uses typed component internals and resizing rules. |
Review effort: Balanced
pharret31
force-pushed
the
typescript/scheduler/typing_5270_part2
branch
from
October 23, 2026 14:28
aa47ead to
85ffae0
Compare
pharret31
force-pushed
the
typescript/scheduler/typing_5270_part2
branch
from
October 23, 2026 15:56
85ffae0 to
3160400
Compare
aleksei-semikozov
previously approved these changes
Oct 23, 2026
…and the unused resources option
…ig always overrides
…d of the undeclared _getTemplateByOption()
pharret31
force-pushed
the
typescript/scheduler/typing_5270_part2
branch
from
October 26, 2026 09:17
3160400 to
451dc98
Compare
aleksei-semikozov
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.