Repository navigation
Scheduler: remove the m_ prefix from the appointment, subscribes, drag and data source files - #35839
Merged
pharret31 merged 1 commit intoOct 26, 2026
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Resize calculations mutate shared cell data and mix source dates with grid-time dates.
No open issues 🎉
What changed in this PR
Removes m_ prefixes from Scheduler internals and strengthens typing across appointment rendering, resizing, dragging, and data access.
Changes:
- Renames internal modules and updates their consumers and tests.
- Replaces loose types with explicit interfaces.
- Removes obsolete date-formatting utilities and modernizes a test mock.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/subscribes.tests.js | Updates subscription import. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.appointmentCollector.tests.js | Updates import and widget mock. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.markup.tests.js | Updates data-source import. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.initialization.tests.js | Updates data-source import. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointments.tests.js | Updates collection import. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.tests.js | Updates appointment import. |
| packages/devextreme/js/__internal/ui/resizable/resizable.ts | Allows numeric resize steps. |
| packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts | Updates imports and drag types. |
| packages/devextreme/js/__internal/scheduler/view_model/types.ts | Narrows appointment orientation. |
| packages/devextreme/js/__internal/scheduler/view_model/appointment_data_source.ts | Renames module and adjusts lint directives. |
| packages/devextreme/js/__internal/scheduler/utils_time_zone.ts | Accepts numeric timestamps. |
| packages/devextreme/js/__internal/scheduler/types.ts | Refines collector callback type. |
| packages/devextreme/js/__internal/scheduler/tooltip_strategies/tooltip_strategy_base.ts | Narrows date-format type. |
| packages/devextreme/js/__internal/scheduler/subscribes.ts | Types Scheduler callbacks. |
| packages/devextreme/js/__internal/scheduler/scheduler.ts | Updates imports and internal contracts. |
| packages/devextreme/js/__internal/scheduler/compact_appointments_helper.ts | Types collector rendering and events. |
| packages/devextreme/js/__internal/scheduler/base/widget_notify_scheduler.ts | Updates subscription import. |
| packages/devextreme/js/__internal/scheduler/appointments/utils/get_view_model_diff.ts | Updates data-source import. |
| packages/devextreme/js/__internal/scheduler/appointments/resizing/core.ts | Provides renamed resize calculations. |
| packages/devextreme/js/__internal/scheduler/appointments/resizing/core.test.ts | Updates resizing import. |
| packages/devextreme/js/__internal/scheduler/appointments/m_text_utils.ts | Removes obsolete formatting utilities. |
| packages/devextreme/js/__internal/scheduler/appointments/appointments_kbn.ts | Updates imports and type suppressions. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/types.ts | Defines appointment property types. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/text_utils.ts | Updates property-type import. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/appointment.ts | Strengthens component typing. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/agenda_appointment.ts | Updates base appointment import. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment_layout.ts | Types layout inputs and output. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment_collection.ts | Types collection rendering and resizing. |
| packages/devextreme/js/__internal/scheduler/appointment_drag_behavior.ts | Types drag events and state. |
Review effort: Balanced
pharret31
force-pushed
the
typescript/scheduler/rename_5270
branch
from
October 23, 2026 14:28
50dd57c to
f560400
Compare
pharret31
force-pushed
the
typescript/scheduler/rename_5270
branch
from
October 23, 2026 15:56
f560400 to
c9156fd
Compare
aleksei-semikozov
previously approved these changes
Oct 23, 2026
pharret31
force-pushed
the
typescript/scheduler/rename_5270
branch
from
October 26, 2026 09:17
c9156fd to
f5bb7a1
Compare
…g and data source files
pharret31
force-pushed
the
typescript/scheduler/rename_5270
branch
from
October 26, 2026 12:40
f5bb7a1 to
8be1f1b
Compare
aleksei-semikozov
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.