Skip to content

Grids: remove editing hacks and type cross-extender overrides - #35932

Open
anna-shakhova wants to merge 6 commits into
DevExpress:mainfrom
anna-shakhova:cleanup_editing_strategies_main
Open

anna-shakhova wants to merge 6 commits into
DevExpress:mainfrom
anna-shakhova:cleanup_editing_strategies_main

Conversation

@anna-shakhova

@anna-shakhova anna-shakhova commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
  1. Remove the TreeList row-click hacks from the editing rows view
  • Core: _rowClickTreeListHack and _rowDblClickTreeListHack are removed from the core editing rows-view extender. The editing part of a row click / double-click now lives in two overridable methods on EditingRowsViewExtension: handleRowClickByEditing and handleRowDblClickByEditing.
  • TreeList: these methods return false on the expand-icon container, so the click goes to the rows view and the editing marker isn't set. _rowClick / _rowDblClick keep only the select-checkbox guard. This removes validateClick, needToCallOriginalClickHandler, the event-type switch and two @ts-expect-error.
  1. Unify edit-mode checks
  • New pure helpers: isCellBasedEditMode, isRowBasedEditMode and isFormBasedEditMode. Single-mode checks are written as getEditMode() === EDIT_MODE.x.
  • Removed: 14 duplicate or clashing methods across editing, adaptivity and keyboard navigation.
  • Raw reads: reads of option('editing.mode') now go through getEditMode().
  1. _beforeEditCell is now in CellBasedEditingControllerExtension and is public, because an interface can't hold a protected member. Validating's _beforeEditCell is public override with item
  2. Made NormalizedEditCellOptions.column optional, added PrepareEditCellOptions with required
  3. Form-based editing called validating's private _getValidationGroupsInForm under @ts-expect-error. Validating now overrides the typed getEditFormOptions and adds validationGroup to its result. Call order and result are unchanged.
  4. Move the toolbar item type and normalizer from CardView to grid_core

@anna-shakhova anna-shakhova changed the title Grids: cleanup editing strategies Grids: clean up editing strategies Oct 26, 2026
@anna-shakhova anna-shakhova changed the title Grids: clean up editing strategies Grids: remove editing hacks and type cross-extender overrides Oct 26, 2026
@anna-shakhova
anna-shakhova marked this pull request as ready for review October 26, 2026 12:27
@anna-shakhova
anna-shakhova requested a review from a team as a code owner October 26, 2026 12:27
@anna-shakhova anna-shakhova self-assigned this Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant