Repository navigation
Core: type position and the collection data controller - #35945
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new offset parameter type excludes supported event inputs and should preserve that capability for typed callers.
1 open issue
What changed in this PR
This PR strengthens TypeScript typing for DevExtreme’s internal positioning utilities and collection data controller, and updates their UI consumers.
Changes:
- Introduces shared position types and typed positioning functions.
- Adds data-controller signatures and accessor overloads, removing obsolete casts and suppressions.
- Adds defensive handling for missing positioning results.
| File | Description |
|---|---|
packages/devextreme/js/__internal/ui/tag_box.ts |
Removes an obsolete suppression and documents promise handling. |
packages/devextreme/js/__internal/ui/select_box.ts |
Removes an obsolete search-value suppression. |
packages/devextreme/js/__internal/ui/popover/popover.ts |
Handles missing position results and offsets. |
packages/devextreme/js/__internal/ui/overlay/overlay_position_controller.ts |
Updates the initial-position type. |
packages/devextreme/js/__internal/ui/list/list.edit.search.ts |
Removes an obsolete filter suppression. |
packages/devextreme/js/__internal/ui/drop_down_editor/drop_down_list.ts |
Uses typed controller results without redundant casts. |
packages/devextreme/js/__internal/ui/drop_down_editor/drop_down_editor.ts |
Guards missing offsets when determining popup position. |
packages/devextreme/js/__internal/ui/collection/m_data_controller.ts |
Types controller methods and accessor overloads. |
packages/devextreme/js/__internal/ui/collection/collection_widget.edit.ts |
Adjusts suppressions for typed controller calls. |
packages/devextreme/js/__internal/common/core/animation/types.ts |
Defines shared positioning interfaces and target types. |
packages/devextreme/js/__internal/common/core/animation/m_position.ts |
Types positioning helpers and setup overloads. |
Review effort: Balanced
pharret31
force-pushed
the
5382-coremisc-remove-m_-prefix-improve-typing-of-position-the-collection-data-controller-and-the-themes-callback
branch
from
October 26, 2026 15:54
354ade5 to
cac3b64
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.