Skip to content

Grids: type m_sticky_columns #35948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alyar666 wants to merge 8 commits into
base: main
Choose a base branch
from
+241 −154
Open

Grids: type m_sticky_columns #35948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1180109
Grids: add sticky columns types
Alyar666 Oct 26, 2026
503d04d
Grids: type sticky columns base extender
Alyar666 Oct 26, 2026
53d6bde
Grids: type sticky columns headers view
Alyar666 Oct 26, 2026
6f1e0ac
Grids: type sticky columns rows view
Alyar666 Oct 26, 2026
04991c5
Grids: type sticky columns controller extenders
Alyar666 Oct 26, 2026
3e464a9
Grids: add reasons to sticky columns directives
Alyar666 Oct 26, 2026
20919d3
Grids: fix sticky columns lint warnings
Alyar666 Oct 26, 2026
92056d9
Grids: simplify sticky columns code
Alyar666 Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...s/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { CLASSES as COLUMN_HEADERS_CLASSES } from '@ts/grids/grid_core/column_he
import { getDraggingPanelBoundingRects } from '@ts/grids/grid_core/columns_resizing_reordering/utils';
import type { EditorFactory } from '@ts/grids/grid_core/editor_factory/editor_factory';
import type {
ColumnPoint, InternalGrid, ModuleType, OptionChanged,
ColumnPoint, ColumnPointProps, InternalGrid, ModuleType, OptionChanged,
} from '@ts/grids/grid_core/types';
import type { RowsView } from '@ts/grids/grid_core/views/rows_view';
import type { ScrollPosition } from '@ts/grids/grid_core/views/types';
Expand Down Expand Up @@ -799,7 +799,7 @@ export class ColumnsResizerViewController extends modules.ViewController {
}

protected _correctColumnIndexForPoint(
point: ColumnPoint,
point: ColumnPointProps,
correctionValue: number,
// eslint-disable-next-line @typescript-eslint/no-unused-vars -- overrides use the param
columns: Column[],
Expand All @@ -811,7 +811,7 @@ export class ColumnsResizerViewController extends modules.ViewController {
* @extended: adaptivity
*/
protected _pointCreated(
point: ColumnPoint,
point: ColumnPointProps,
columns: Column[],
cells?: dxElementWrapper,
): boolean {
Expand Down Expand Up @@ -1082,7 +1082,7 @@ export class ColumnsResizerViewController extends modules.ViewController {
const topYMap = this._generateColumnsTopYIndex(needToCheckPrevPoint);
const columns = this._columnsController ? this._columnsController.getVisibleColumns() : [];
const cells = this._columnHeadersView.getColumnElements();
const correctColumnY = (point: ColumnPoint): ColumnPoint => {
const correctColumnY = (point: ColumnPointProps): ColumnPointProps => {
const x = Math.ceil(point.x);

if (topYMap[x]) {
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/grids/grid_core/grid_view/grid_view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class ResizingController extends modules.ViewController {

protected _rowsView!: RowsView;

private _columnHeadersView!: ColumnHeadersView;
protected _columnHeadersView!: ColumnHeadersView;

public _columnsController!: ColumnsController;

Expand Down
9 changes: 2 additions & 7 deletions packages/devextreme/js/__internal/grids/grid_core/sticky_columns/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type { dxElementWrapper } from '@js/core/renderer';
import $ from '@js/core/renderer';
import { getBoundingRect } from '@js/core/utils/position';
import { isDefined } from '@js/core/utils/type';
import type { ColumnPointProps } from '@ts/grids/grid_core/types';

import type { ColumnHeadersView } from '../column_headers/m_column_headers';
import { CLASSES, StickyPosition } from './const';
Expand Down Expand Up @@ -196,13 +197,7 @@ const noNeedToCreateResizingPoint = (
nextColumn,
cells,
}: {
point: {
x: number;
index: number;
item: HTMLElement;
isLeftBoundary: boolean | undefined;
isRightBoundary: boolean | undefined;
};
point: ColumnPointProps;
column;
nextColumn;
cells: dxElementWrapper | undefined;
Expand Down
Loading
Loading