Repository navigation
Core: remove the m_ prefix from position, the collection data controller and the themes callback - #35949
Open
pharret31 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports consistent renames and compatible typing updates with no blocking issues identified; builds and tests were not run.
No open issues 🎉
What changed in this PR
Removes the m_ prefix from three internal core modules and updates their consumers, while strengthening TypeScript types for positioning and collection data access.
Changes:
- Renames internal modules and updates public entry points, consumers, and test imports.
- Adds explicit data-controller signatures and shared positioning types.
- Adjusts callers for stricter types, including guards for missing position results.
| File | Description |
|---|---|
packages/devextreme/js/ui/themes_callback.js |
Reexports the renamed callback module. |
packages/devextreme/js/common/core/animation/position.js |
Reexports the renamed position module. |
packages/devextreme/js/__internal/ui/themes.ts |
Updates the callback import. |
packages/devextreme/js/__internal/ui/themes_callback.ts |
Houses callbacks under the new name. |
packages/devextreme/js/__internal/ui/tag_box.ts |
Removes an obsolete type suppression and adds a lint exemption. |
packages/devextreme/js/__internal/ui/select_box.ts |
Removes an obsolete type suppression. |
packages/devextreme/js/__internal/ui/popover/popover.ts |
Handles missing position results and offsets. |
packages/devextreme/js/__internal/ui/overlay/overlay.ts |
Updates the callback import. |
packages/devextreme/js/__internal/ui/overlay/overlay_position_controller.ts |
Refines the initial-position type. |
packages/devextreme/js/__internal/ui/list/list.edit.search.ts |
Removes an obsolete type suppression. |
packages/devextreme/js/__internal/ui/drop_down_editor/drop_down_list.ts |
Updates the controller import and removes redundant casts. |
packages/devextreme/js/__internal/ui/drop_down_editor/drop_down_editor.ts |
Guards missing offsets when determining popup placement. |
packages/devextreme/js/__internal/ui/collection/m_data_controller.ts |
Removes the old controller path. |
packages/devextreme/js/__internal/ui/collection/data_controller.ts |
Introduces the renamed, explicitly typed controller. |
packages/devextreme/js/__internal/ui/collection/collection_widget.edit.ts |
Updates the controller import and type suppressions. |
packages/devextreme/js/__internal/ui/__tests__/themes.test.ts |
Updates the callback test import. |
packages/devextreme/js/__internal/pagination/utils/on_theme_ready.ts |
Uses the renamed callback module. |
packages/devextreme/js/__internal/pagination/__tests__/pages-small.test.ts |
Updates the callback test import. |
packages/devextreme/js/__internal/pagination/__tests__/on-theme-ready.test.ts |
Updates the callback test import. |
packages/devextreme/js/__internal/pagination/__tests__/adaptive-theme-ready.test.ts |
Updates the callback test import. |
packages/devextreme/js/__internal/integration/jquery/hold_ready.ts |
Updates the jQuery integration callback import. |
packages/devextreme/js/__internal/data/m_data_helper.ts |
Imports the renamed data controller. |
packages/devextreme/js/__internal/common/core/animation/types.ts |
Defines shared positioning types. |
packages/devextreme/js/__internal/common/core/animation/position.ts |
Types positioning helpers and adds setup overloads. |
packages/devextreme/js/__internal/common/core/animation/position.test.ts |
Imports the renamed position module. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.