Nl/job table - #159
Merged
Merged
Conversation
yousefmoazzam
requested changes
Sep 3, 2026
yousefmoazzam
left a comment
yousefmoazzam
left a comment
Collaborator
There was a problem hiding this comment.
Nice, there's a lot of good stuff in here, thanks!
I haven't fully absorbed it all yet, but I've had a first pass at it. A few suggestions, and then one question to learn a bit more about fragments, hope that's OK!
yousefmoazzam
approved these changes
Sep 4, 2026
yousefmoazzam
left a comment
yousefmoazzam
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this, it's a great start to the jobs table!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a skeleton JobsTable. The table can list the workflows in the visit and display their current status.
Currently, the visit passed to the JobsViewer (where I'm assuming the plotting and logs will also go) is hard coded to match a visit with workflows on staging. Plus I also wasn't sure how the visit would be handled/passed to it in the first place.
There is also a known issue in the Analysis Platform with graphql pagination keys not working correctly. The results is that changing the table page doesn't give you the correct list of items.