Skip to content

Add API endpoints to find and return client-side OTF directories - #876

Merged
tieneupin merged 9 commits into
mainfrom
detect-otf-files
Sep 2, 2026
Merged

Add API endpoints to find and return client-side OTF directories#876
tieneupin merged 9 commits into
mainfrom
detect-otf-files

Conversation

@tieneupin

@tieneupin tieneupin commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
  • The backend server will send a GET request to the instrument server requesting for OTF directories
  • The instrument server will load the machine config and look for top-level folders under the configured gain_reference_directory field

Actual diff is about +90/-1, with the rest of the diff being due to the addition and modification of tests.

NOTE: This PR is tied to DiamondLightSource/murfey-frontend#81 and will have to be deployed along side the version that contains it.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.72%. Comparing base (4b78c30) to head (2206baf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   54.60%   54.72%   +0.12%     
==========================================
  Files         101      101              
  Lines       11311    11337      +26     
  Branches     1503     1507       +4     
==========================================
+ Hits         6176     6204      +28     
+ Misses       4808     4806       -2     
  Partials      327      327              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin self-assigned this Sep 2, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component client Relates to the client component cryo-sim Part of the cryo-SIM pipeline extension labels Sep 2, 2026
@tieneupin
tieneupin marked this pull request as ready for review September 2, 2026 09:39

@stephen-riggs stephen-riggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, with one comment about an optional path

Comment thread src/murfey/instrument_server/api.py Outdated
@tieneupin
tieneupin merged commit 6466bcd into main Sep 2, 2026
14 checks passed
@tieneupin
tieneupin deleted the detect-otf-files branch September 2, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component cryo-sim Part of the cryo-SIM pipeline extension enhancement New feature or request server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants