Improve theme architecture and MRT compatibility#245
Open
zoharma wants to merge 5 commits into
Open
Conversation
zoharma
force-pushed
the
zma/ds-mta-theme-update
branch
3 times, most recently
from
4acd5dd to
b000b7c
Compare
zoharma
force-pushed
the
zma/ds-mta-theme-update
branch
from
b000b7c to
aa36969
Compare
zoharma
force-pushed
the
zma/ds-mta-theme-update
branch
from
aa36969 to
b03ac5c
Compare
|
|
||
| /** | ||
| * Standard argument shape for MUI style override callbacks. | ||
| * |
Collaborator
There was a problem hiding this comment.
Why was this deleted?
Contributor
Author
There was a problem hiding this comment.
I changed it because the comment describes the whole type, not just the ownerState field. The old comment only explained one part of it, while the new one explains what the type is used for.
VictoriaBeilsten-Edmands
requested changes
Jul 10, 2026
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
Collaborator
There was a problem hiding this comment.
The tests can be extended now to check that the vales introduced to the theme file match those in the css file.
- Working towards MRT support with the new theme - Added fallback light/dark hex values for MUI compatibility - Updated and cleaned up theme overrides to consume design tokens only - Reorganised the theme file and improved comments - Updated comments
zoharma
force-pushed
the
zma/ds-mta-theme-update
branch
from
ac75ce0 to
8159aa3
Compare
zoharma
force-pushed
the
zma/ds-mta-theme-update
branch
from
d80fdc6 to
0b818ea
Compare
… the MuiTab &:hover rule in the DiamondDS theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.