Skip to content

Add workflow parameter filtering and Display Logs in workflow UI - #1561

Open
hazdl wants to merge 24 commits into
mainfrom
hz/filters-param
Open

Add workflow parameter filtering and Display Logs in workflow UI#1561
hazdl wants to merge 24 commits into
mainfrom
hz/filters-param

Conversation

@hazdl

@hazdl hazdl commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR combines two enhancements:

Workflow Parameter Filtering --- AP-1206

  • Added WorkflowParameterFilter and parameters support to WorkflowFilter
  • Implemented parameter matching against workflow.spec.arguments.parameters
  • Added unit test coverage for:
    • Matching parameters
    • Incorrect values
    • Missing parameters
    • No filter specified
    • Multiple parameter matching
    • Partial mismatches
    • Workflows without arguments/parameters

Display Logs Subscription on Workflow --- AP-1112

  • Added real time tasks logs, and support for retrieving archived task logs from S3 using:

    <workflow-name>/<task-id>/main.log

  • Running tasks continue to use the existing GraphQL subscription and stream logs in real time

  • Completed tasks retrieve archived logs from S3

  • Fixed S3 configuration issues including:

    • Endpoint configuration
    • Path-style URL support
    • Credentials
    • Bucket configuration
  • Added filtering of Argo infrastructure log noise from displayed logs

Result

Running task:

  • Live pod log stream

Completed task:

  • Archived main.log retrieved from S3

Workflow searches can now also be filtered using workflow parameter values.

@davehadley davehadley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sent some comments via slack

@iamvigneshwars

Copy link
Copy Markdown
Contributor

Maybe for future PRs, it would be better to keep commits meaningful and grouped logically, rather than creating a separate commit for every small file change. Since we follow Conventional Commits and use them for releases, please also keep the format consistent, e.g. fix/feat/chore(scope): message, so the history and release notes stay clean.
For example, feat(workflows): add parameter filtering could include all changes related to that feature in a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants