Add workflow parameter filtering and Display Logs in workflow UI - #1561
Open
hazdl wants to merge 24 commits into
Open
Add workflow parameter filtering and Display Logs in workflow UI#1561hazdl wants to merge 24 commits into
hazdl wants to merge 24 commits into
Conversation
This reverts commit ecf0ea58bb19365692a991f388e7474f47b7b025.
This reverts commit 954aadd.
hazdl
requested review from
JamesDoingStuff,
TBThomas56,
davehadley and
iamvigneshwars
August 24, 2026 11:30
davehadley
requested changes
Aug 24, 2026
davehadley
left a comment
Collaborator
There was a problem hiding this comment.
sent some comments via slack
Contributor
|
Maybe for future PRs, it would be better to keep commits meaningful and grouped logically, rather than creating a separate commit for every small file change. Since we follow Conventional Commits and use them for releases, please also keep the format consistent, e.g. fix/feat/chore(scope): message, so the history and release notes stay clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines two enhancements:
Workflow Parameter Filtering --- AP-1206
WorkflowParameterFilterandparameterssupport toWorkflowFilterworkflow.spec.arguments.parametersDisplay Logs Subscription on Workflow --- AP-1112
Added real time tasks logs, and support for retrieving archived task logs from S3 using:
<workflow-name>/<task-id>/main.logRunning tasks continue to use the existing GraphQL subscription and stream logs in real time
Completed tasks retrieve archived logs from S3
Fixed S3 configuration issues including:
Added filtering of Argo infrastructure log noise from displayed logs
Result
Running task:
Completed task:
main.logretrieved from S3Workflow searches can now also be filtered using workflow parameter values.