Skip to content

more robust envoy #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davehadley merged 3 commits into from
Aug 27, 2026
Merged

more robust envoy #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38a29bc
fix(envoy): increase envoy memory limits to prevent OOM crash sometim…
davehadley Aug 26, 2026
a03b003
fix(envoy): wait for envoy ready before initializing workflow containers
davehadley Aug 26, 2026
7bb2789
chore(charts): increment workflows chart version number
davehadley Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/workflows/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: workflows
description: Data Analysis workflow orchestration
type: application
version: 0.13.67
version: 0.13.68
dependencies:
- name: argo-workflows
repository: https://argoproj.github.io/argo-helm
Expand Down
21 changes: 18 additions & 3 deletions charts/workflows/templates/inject-envoy-sidecar-clusterpolicy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ spec:
# GraphQL server
- |
cat > /etc/envoy/envoy.yaml << 'ENVOYEOF'
admin:
address:
socket_address:
address: 0.0.0.0
port_value: 9901
allow_paths:
- exact: /ready
static_resources:
listeners:
- name: envoy-local-graph-proxy
Expand Down Expand Up @@ -320,12 +327,20 @@ spec:
- "--log-level"
- "{{ .Values.authenticatedWorkflows.envoy.logLevel | default "warn" }}"
startupProbe:
tcpSocket:
port: 6000
httpGet:
port: 9901
path: /ready
initialDelaySeconds: 1
periodSeconds: 1
failureThreshold: 30
failureThreshold: 60
timeoutSeconds: 1
readinessProbe:
httpGet:
port: 9901
path: /ready
periodSeconds: 10
timeoutSeconds: 1
failureThreshold: 3
volumeMounts:
- name: workflows-envoy-config
mountPath: /etc/envoy
Expand Down
4 changes: 2 additions & 2 deletions charts/workflows/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ authenticatedWorkflows:
resources:
requests:
cpu: 100m
memory: 32Mi
memory: 128Mi
limits:
# limit range doesn't allow a smaller value
cpu: 1000m
memory: 64Mi
memory: 256Mi
Loading