Add dissmodel-configs TOML examples and a working local CLI for the e… - #1
Merged
Merged
Conversation
…xecutors
- examples/dissmodel-configs/lucc_{continuous,discrete}.toml: registration
config for dissmodel-platform, encoding the same coefficients as
examples/run_*_via_executor.py
- Wire up `python -m disslucc.executors.<name> run --toml ... --input ...`
(if __name__ == "__main__": run_cli(...)) — didn't exist before
- Fix TOML table names ([[model.potential_data]]/[[model.allocation_data]],
not potential/allocation) to match this package's required_parameters
- Lazy-import executors (PEP 562) to silence the RuntimeWarning `python -m`
raised from disslucc/executors/__init__.py's eager imports
- LuccExecutorBase.save() now actually writes the output GeoTIFF (local
path or s3:///MinIO, via dissmodel.io.raster.save_geotiff) instead of
only hashing the backend's raw bytes in memory — record.output_path/
--output were silently ignored before this
Requires a dissmodel release past 0.6.3 (upstream fix: DisSModel/dissmodel#176)
for the --toml merge to work locally; see docs/decisions.md for the full
history and verification of each step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…xecutors
python -m disslucc.executors.<name> run --toml ... --input ...(if name == "main": run_cli(...)) — didn't exist beforepython -mraised from disslucc/executors/init.py's eager importsRequires a dissmodel release past 0.6.3 (upstream fix: DisSModel/dissmodel#176) for the --toml merge to work locally; see docs/decisions.md for the full history and verification of each step.
Description
Related Issue
Closes #
Changes Made
src/disslucc/components/,executors/)tests/)Contributor Checklist
pytest tests/ -v)mypy src/disslucc)docs/validation.md(andpaper.md/paper.bibindissmodel, if applicable) is updated tomatch -- these numbers are cited externally