Skip to content

Add dissmodel-configs TOML examples and a working local CLI for the e… - #1

Merged
profsergiocosta merged 1 commit into
mainfrom
feat/executors-toml-cli-output
Sep 22, 2026
Merged

profsergiocosta merged 1 commit into
mainfrom
feat/executors-toml-cli-output

Conversation

@profsergiocosta

Copy link
Copy Markdown
Member

…xecutors

  • examples/dissmodel-configs/lucc_{continuous,discrete}.toml: registration config for dissmodel-platform, encoding the same coefficients as examples/run_*_via_executor.py
  • Wire up python -m disslucc.executors.<name> run --toml ... --input ... (if name == "main": run_cli(...)) — didn't exist before
  • Fix TOML table names ([[model.potential_data]]/[[model.allocation_data]], not potential/allocation) to match this package's required_parameters
  • Lazy-import executors (PEP 562) to silence the RuntimeWarning python -m raised from disslucc/executors/init.py's eager imports
  • LuccExecutorBase.save() now actually writes the output GeoTIFF (local path or s3:///MinIO, via dissmodel.io.raster.save_geotiff) instead of only hashing the backend's raw bytes in memory — record.output_path/ --output were silently ignored before this

Requires a dissmodel release past 0.6.3 (upstream fix: DisSModel/dissmodel#176) for the --toml merge to work locally; see docs/decisions.md for the full history and verification of each step.

Description

Related Issue

Closes #

Changes Made

  • Core implementation / algorithmic changes (src/disslucc/components/, executors/)
  • Added or updated unit tests (tests/)
  • Updated documentation / docstrings / examples

Contributor Checklist

  • The code runs locally without errors
  • All unit tests pass locally (pytest tests/ -v)
  • Static analysis passes (mypy src/disslucc)
  • Docstrings follow the project standard (inputs, outputs, exceptions)
  • If this changes a Lab1 or Lab15 result, docs/validation.md (and
    paper.md/paper.bib in dissmodel, if applicable) is updated to
    match -- these numbers are cited externally

…xecutors

- examples/dissmodel-configs/lucc_{continuous,discrete}.toml: registration
  config for dissmodel-platform, encoding the same coefficients as
  examples/run_*_via_executor.py
- Wire up `python -m disslucc.executors.<name> run --toml ... --input ...`
  (if __name__ == "__main__": run_cli(...)) — didn't exist before
- Fix TOML table names ([[model.potential_data]]/[[model.allocation_data]],
  not potential/allocation) to match this package's required_parameters
- Lazy-import executors (PEP 562) to silence the RuntimeWarning `python -m`
  raised from disslucc/executors/__init__.py's eager imports
- LuccExecutorBase.save() now actually writes the output GeoTIFF (local
  path or s3:///MinIO, via dissmodel.io.raster.save_geotiff) instead of
  only hashing the backend's raw bytes in memory — record.output_path/
  --output were silently ignored before this

Requires a dissmodel release past 0.6.3 (upstream fix: DisSModel/dissmodel#176)
for the --toml merge to work locally; see docs/decisions.md for the full
history and verification of each step.
@profsergiocosta
profsergiocosta merged commit 404c61d into main Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] run_cli's local --toml loader doesn't merge resolved_spec into record.parameters, contradicting ModelExecutor.run()'s documented contrac

1 participant