Repository navigation
Preparation for PHPStan 2.3's unused function parameter warning - #1690
Merged
cpeel merged 4 commits intoOct 20, 2026
Merged
Conversation
So PHPStan 2.3 can ignore them. This naming convention is used in the Rust compiler & in Python linters.
These functions all need to have the same type signature as functions from PHPBB, so even though these dummy/test functions don't use the parameters, we need to keep them.
cpeel
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan 2.3 introduces a very useful function.unusedParameter warning.
In a few places in the code we have functions that must implement a specific API, even though they don't use all the function parameters, and we prefix all these parameter names with
_.PHPStan itself doesn't ignore unused parameters prefixed with
_, as it does for variable assignments, but we can write aphpstan.neonignoreErrorsrule that allows us to ignore them, which we can add once we upgrade to PHPStan 2.3.