fix: preserve application status when saving provider settings - #5455
roshanasingh4 wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| vi.clearAllMocks(); | ||
| }); | ||
|
|
||
| it.each(["done", "running"])( |
There was a problem hiding this comment.
This test invokes only saveGithubProvider, but the PR independently changes five other provider-save handlers and the separate disconnect handler. A provider-specific regression or unintended status reset during disconnect could therefore pass the test suite. Extend the table-driven coverage to each changed mutation, especially disconnectGitProvider.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
What is this PR about?
Saving provider settings on an existing application currently changes its stored status to
idle. For example, editing GitHub watch paths makes a running application show a gray status dot and a Start button even though its container is still running. Provider settings do not start or stop the service, so these save handlers now leave application status unchanged.Validation
doneandrunningstatuses.