fix(guest-agent): stop an anonymous Info from driving a quote and a KMS round trip - #1263
Merged
Merged
Conversation
Collaborator
Author
|
Follow-up commit 5d3ebe1 also moves the residual startup-identity retry path off the executor and coalesces concurrent retries; cancellation retains the guard. |
kvinwang
force-pushed
the
fix/guest-agent-residuals
branch
from
September 24, 2026 07:56
5d3ebe1 to
805058b
Compare
kvinwang
changed the title
kvinwang
changed the base branch from
next
to
fix/guest-agent-quote-blocking
September 24, 2026 07:56
`get_info` (frozen `Info`, the dashboard and vsock `GuestApi.Info`) attested on every call, and started another demo-cert request (a quote plus a KMS round trip) on every call while the KMS was unreachable. - Serve identity from the existing `identity()` cache, and attest only when `tcb_info` is served. - Keep the demo cert in a `tokio::sync::OnceCell`; a `try_lock` on the last-failure mutex makes the request single-flight, and a failure throttles retries to one per 30s.
kvinwang
force-pushed
the
fix/guest-agent-residuals
branch
from
September 24, 2026 08:09
805058b to
ea3d67b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1256 (base will switch to
nextonce it merges).The frozen
Info(also behind the dashboard and vsockGuestApi.Info) is anonymous, yet it:Changes:
identity()cache; attestation happens only whentcb_infois served (internal callers, orpublic_tcbinfo).demo_certbecomes atokio::sync::OnceCell<String>. Atry_lockon the last-failure mutex makes the request single-flight, and a failure throttles retries to one per 30 s.Tests: 8 anonymous
Infocalls → 0 extra attestations; concurrent + post-failure calls → 1 demo-cert request.The rest of the original PR was split out: #1358, #1359, #1360.