fix(dstack-util): check an omitted MrConfig instance_id as empty - #1323
Merged
Merged
Conversation
kvinwang
force-pushed
the
fix/guest-identity-checks
branch
from
September 23, 2026 02:27
d9feeca to
ef9fa3e
Compare
kvinwang
changed the title
kvinwang
force-pushed
the
fix/guest-identity-checks
branch
from
September 23, 2026 02:41
ef9fa3e to
e6806db
Compare
A relying party cannot tell an omitted instance_id from no_instance_id, so the guest must not skip the check when the host leaves the field out.
kvinwang
changed the title
kvinwang
force-pushed
the
fix/guest-identity-checks
branch
from
September 23, 2026 03:33
e6806db to
e1b4324
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify_mr_config_v3_documentskipped theinstance_idcheck when the host-written document omitted the field. Verifiers read an omittedinstance_idas empty, which is indistinguishable fromno_instance_id; on SEV-SNP this document is its only carrier, so the KMS would derive the disk key fromapp_idalone.Treat an omitted
instance_idas empty, so it is accepted only when the guest also has none (no_instance_id, the one case where the VMM omits it). This restores the strict check that 7bf644a loosened when it made the field optional.app_idis left optional on purpose (6a71d79): an omittedapp_idis attested as empty, which the KMS already rejects, so it cannot be mistaken for a real identity.