fix(os): require dstack-prepare and the guest agent before the app - #1324
Merged
Merged
Conversation
kvinwang
force-pushed
the
fix/app-compose-requires-prepare
branch
from
September 23, 2026 02:36
8c6ea92 to
9f027f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app-compose.serviceonly haddstack-prepare.serviceinAfter=, and a failed unit satisfies that too. So if prepare failed,docker compose upcould still run with no data disk mounted and no keys provisioned, and it would race the queuedFailureAction=reboot.This adds
Requires=dstack-prepare.service dstack-guest-agent.service. Container runtimes stay inWants=because thebashrunner doesn't need them.Note: an explicit
systemctl stop/restart dstack-guest-agentnow also stops/restarts the app.