docs(verifier): say what event_log_verified actually covers - #1335
Merged
Merged
Conversation
The field documented itself as verifying RTMR 0-2 digests "through replay comparison with the quote". Nothing in dstack-verifier or dstack-attest replays a boot-time event log: the flag is set once the runtime event log replays to its register and the app identity decodes out of its payloads. A TDX quote's RTMR 0-2 entries reach only the `--debug` diff and the three named ACPI digests the lite path cross-checks. Correct the comment rather than the code. Replaying RTMR 0-2 would add nothing: those registers are already checked against measurements recomputed from the OS image, which does not trust the host's event log at all, and is the stronger of the two checks.
SEV-SNP has no runtime event log (identity comes from mr_config via HOST_DATA), Nitro Enclave and GCP TDX were missing, and the replay runs during quote verification, so a mismatch fails quote_verified. The --debug diff does not read event log entries, and the lite ACPI digest check is fatal rather than diagnostic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc comment said "For RTMR 0-2 … only the digests are verified through replay comparison with the quote." Grepping every consumer: the flag is set only after
decode_app_info_exsucceeds, which reads the runtime event list replayed against RTMR3.TdxQuote.event_logreaches only the--debugdiff (dead until #1332), three ACPI names on the lite path, andvalidate_v2_preimages, which checks preimage→digest and no register at all.I argued for fixing the comment rather than the code: RTMR 0-2 are already verified by comparing the quoted values against measurements recomputed from the image, which does not trust the host's event log at all. That is strictly stronger than replaying it. The
types.rsdoc andverifier/README.mdstep 2 now say so.Split out of #1251.