Conversation
…filesystem A first boot interrupted between luksFormat and mkfs left a LUKS header with no filesystem. Later boots treated the disk as initialized, failed to import it, and rebooted forever. Open the volume first and only create the filesystem when blkid finds nothing on it.
kvinwang
force-pushed
the
fix/luks-half-initialized-disk
branch
from
September 23, 2026 08:01
49f2b08 to
ed1637d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For encrypted storage
is_disk_initializedonly checks for a LUKS header. A first boot interrupted betweenluksFormatandmkfsleaves a header with no filesystem; every later boot then opens the volume, fails to import/mount it, anddstack-prepare.servicereboots the CVM with no start limit, forever.Now an encrypted, initialized disk is opened first and probed with
blkid -p; only blkid's "nothing found" (exit 2) triggers filesystem creation. Any other outcome is treated as "has a filesystem", so a probe failure can never reformat existing data.Split out of #1243.