Conversation
The local, tpm and none key providers hand out no env crypt key, and a present .encrypted-env was then silently dropped, booting the app with none of its secrets. Refuse to boot instead. Also document that an empty key_provider_id pins nothing, and that the env envelope is bound to the app ID only and can be replayed by the host.
kvinwang
force-pushed
the
fix/encrypted-env-fail-closed
branch
from
September 23, 2026 08:01
240b277 to
fd6a07a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
local,tpmandnonekey providers hand out no env crypt key, anddecrypt_env_varstreated that like "no encrypted env": a present.encrypted-envwas dropped and the app booted with none of its secrets. It now fails closed.The VMM only writes
.encrypted-envafter fetching the app's encrypt pubkey from a KMS, so the newly failing combination was already losing every secret.Docs (
cvm-boundaries.md):key_provider_idpins nothing; the provider identity is still in thekey-providerlaunch event;Split out of #1243. Conflicts trivially with #1233 around
write_env_file.