fix(vmm): restrict listed GPUs to the node's offered devices - #1346
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
attach_mode = "listed",resolve_gpuscopies each requestedslotstraight into-device vfio-pci,host={slot}without checkingcvm.gpu.listing/include/exclude. Any host PCI device is attachable, including one the operator excluded or a non-GPU, and the slot string is never validated (QEMU treats,and=as option separators).Fix
resolve_gpus_with_configrejects a listed slot that is not inGpuConfig::list_devices()— the same setListGpusreturns to the web UI picker. Applies to bothCreateVmandUpdateVm.Compat: the web UI can only pick offered slots, so it is unaffected;
vmm-cli --gpurequests naming an unoffered slot are now rejected. Costs onelspciper listed-GPU request.Split out of #1286.
Verification
cargo test -p dstack-vmm(210 passed),cargo clippy -p dstack-vmm --bins -- -D warnings,cargo fmt --check.