Repository navigation
fix(test): allow peer discovery beyond the sync interval - #1513
Merged
Merged
Conversation
Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three cluster tests wait only 4–5 seconds for initial peer discovery, although the suite configures a 5-second periodic sync interval. On PR #1512,
test_push_periodic_overlapfailed twice; the rerun also failed the initial discovery checks intest_network_partitionandtest_node_status_register_exclude.Give those three setup checks 15 seconds, allowing the periodic sync to run. Keep the subsequent write propagation, network-partition recovery, and registration assertions unchanged, including the separate fast-push timing checks.
Validation: shellcheck/prek and
git diff --checkpass. The full cluster suite will validate the fix in CI. This is separate from the image reproducibility changes in #1512.