Update MOM diagnostics for CMIP7 - #346
Merged
Merged
Conversation
alperaltuntas
requested changes
Sep 8, 2026
alperaltuntas
left a comment
alperaltuntas
left a comment
Member
There was a problem hiding this comment.
@iangrooms I am adding code change suggestions below. Clicking "Apply suggestion" button will get those changes into the yaml file, but you'll also need to manually run the yaml_to_json script.
Co-authored-by: Alper Altuntas <altuntas@ucar.edu>
Co-authored-by: Alper Altuntas <altuntas@ucar.edu>
Co-authored-by: Alper Altuntas <altuntas@ucar.edu>
Co-authored-by: Alper Altuntas <altuntas@ucar.edu>
Co-authored-by: Alper Altuntas <altuntas@ucar.edu>
Collaborator
Author
|
@alperaltuntas thanks for catching these. I have added the updates and am running the tests over again (not pr_mom or aux_mom, just making sure it compiles and runs and generates the requested output). |
Collaborator
Author
|
I have now run a one-month G case and verified that the new diagnostics appear as desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #342 and #345. I have run a G case for one month with this MOM_interface and the latest dev/ncar version of MOM6. See /glade/work/igrooms/cesm.cases/diag_table_test. The output has all the expected variables with all the expected names. One part of #342 that I haven't tested is the part about
flandice. We don't have an active Greenland ice sheet in the G case, so that part still needs to be verified.