fix(quotient): keep repr/pi opaque to SMT#1068
Merged
Merged
Conversation
strub
force-pushed
the
fix-quotient-smt-opaque
branch
from
7d1268d to
816de8c
Compare
The CanonQuotient rewrite made `repr`/`pi` transparent, exposing the subtype (val/insubd) projections and the function-valued `canon` to the SMT backend. On large goals this bloats the emitted problem and defeats the solvers, failing to close goals that previously discharged. Mark `repr`/`pi` as [smt_opaque], defined at their real site so opacity survives the clone `subst`, so consumers see the clean quotient interface (reprK, piK, ...) instead of the subtype encoding. Adapt the DynMatrix.eca proofs that relied on the old transparency to derive size/rows/cols >= 0 and out-of-range-zero inline.
strub
force-pushed
the
fix-quotient-smt-opaque
branch
from
816de8c to
a5e7a71
Compare
mbbarbosa
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CanonQuotient rewrite made
repr/pitransparent, exposing thesubtype (val/insubd) projections and the function-valued
canonto theSMT backend. On large goals this bloats the emitted problem and defeats
the solvers, failing to close goals that previously discharged.
Mark
repr/pias [smt_opaque], defined at their real site so opacitysurvives the clone
subst, so consumers see the clean quotient interface(reprK, piK, ...) instead of the subtype encoding.
Adapt the DynMatrix.eca proofs that relied on the old transparency to
derive size/rows/cols >= 0 and out-of-range-zero inline.