tests: fix flaky listchannels doc example generation#9328
Open
ksedgwic wants to merge 1 commit into
Open
Conversation
…e its l4 channel The Update examples in doc schemas CI job intermittently fails with the l3->l4 direction of their channel flipping between disabled and enabled in the regenerated listchannels example (channel_flags 3 vs 1, active false vs true). l4's database is deleted to generate the recoverchannel example, after which l3 disables its side of the l3-l4 channel. That disabling channel_update is emitted lazily (via an error reply or the gossip refresh timer), so whether it lands in l3's gossip store before the listchannels snapshot is a race; the committed example captured the post-disable state. Wait for the disable explicitly, as the script already does for the post-close listchannels races. Fixes: ElementsProject#9327 Changelog-None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Update examples in doc schemasCI job intermittently fails with the l3->l4 direction of their channel flipping between disabled and enabled in the regeneratedlistchannelsexample (channel_flags3 vs 1,activefalse vs true). Two occurrences on 2026-07-17 alone, on unrelated PRs (#9286, #9324).l4's database is deleted to generate the
recoverchannelexample, after which l3 disables its side of the l3-l4 channel. That disabling channel_update is emitted lazily (via an error reply or the gossip refresh timer), so whether it lands in l3's gossip store before thelistchannelssnapshot is a race; the committed example captured the post-disable state. Wait for the disable explicitly before snapshotting, matching the wait_for pattern the script already uses for the post-close listchannels races.Verified by regenerating the examples locally: the listchannels flip no longer appears.
Fixes #9327