dualopend: handle tx_add_output with over MAX_MONEY - #9493
Open
Lagrang3 wants to merge 2 commits into
Open
Conversation
Lagrang3
force-pushed
the
check-max-money-tx-add-output
branch
from
September 10, 2026 16:52
5525a6a to
679a200
Compare
jaonoctus
reviewed
Sep 10, 2026
jaonoctus
left a comment
jaonoctus
left a comment
Collaborator
There was a problem hiding this comment.
Left some comments. Also, no new tests for this?
Harden the handling of tx_add_output messages. Fail the negotiation if the sum of the outputs exceeds 21M BTC. Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Make the MAX_MONEY checks of tx_add_output into an internal API that we can re-use in interactivetx (used by splices) and dualopend. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
check-max-money-tx-add-output
branch
from
September 11, 2026 07:06
679a200 to
9a5e6c9
Compare
Collaborator
Author
|
@jaonoctus, I am working on tests now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden the handling of tx_add_output messages.
Fail the negotiation if the sum of the outputs exceeds 21M BTC.
Fixes #9492