Skip to content

bitcoind: fix byte order of block hash from getrawblockbyheight #9494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andezion wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

bitcoind: fix byte order of block hash from getrawblockbyheight #9494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightningd/bitcoind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ getrawblockbyheight_callback(const char *buf, const jsmntok_t *toks,
}

err = json_scan(tmpctx, buf, resulttok, "{blockhash:%,block:%}",
JSON_SCAN(json_to_sha256, &blkid.shad.sha),
JSON_SCAN(json_to_bitcoin_blkid, &blkid),
JSON_SCAN_TAL(tmpctx, json_strdup, &block_str));
if (err)
bitcoin_plugin_error(call->bitcoind, buf, resulttok,
Expand Down
3 changes: 3 additions & 0 deletions tests/test_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ def test_block_backfill(node_factory, bitcoind, chainparams):
heights = [r['height'] for r in l3.db_query("SELECT height FROM blocks")]
assert(103 in heights)

stored_hash = only_one(l3.db_query("SELECT hash FROM blocks WHERE height = 103"))['hash']
assert bytes(stored_hash) == bytes.fromhex(bitcoind.rpc.getblockhash(103))[::-1]

# Make sure we also have the needle we added to the haystack above
assert(31337 in [r['satoshis'] for r in l3.db_query("SELECT satoshis FROM utxoset")])

Expand Down
Loading