Fix standalone Unit Frames font cache on startup - #1981
Merged
EllesmereGaming merged 1 commit intoSep 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a standalone startup path that can leave Unit Frames using Expressway even when the saved global font is Friz Quadrata TT.
Standalone runtime files can call
GetFontPathbefore the addon's SavedVariables load, caching the temporary default. Invalidate that cache in the existing standaloneADDON_LOADEDbranch, after database rerooting and before queued initialization. Frame initialization then resolves the saved font choice.Five lines in
EllesmereUI_Lite.lua. The full-suite path is unchanged. One startup invalidation; no new timers, event registrations, frames, or per-frame work.How was it tested?
git diff --checkpasses.luac; the added code uses only Lua 5.1 syntax.Additional reproduction/regression checklist (individual steps not separately recorded): select Friz Quadrata TT, fully exit and relaunch WoW, then inspect target/focus text and target castbar before
/reload. Repeat with Expressway and a Unit Frames font override; verify/reloadpreserves the selection.Screenshots
Before/after screenshots are not available. This restores the selected font; it adds no new UI.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - N/A: only the addon's font cache is invalidated.