Add optional decimal literal normalization - #50
Merged
osipovartem merged 2 commits intoSep 1, 2026
Conversation
…nto snowflake-decimal-literals
osipovartem
changed the base branch from
qualified-wildcard-options
to
expr-planner-aggregate-schema
September 1, 2026 23:58
osipovartem
merged commit Sep 1, 2026
a4762a3
into
expr-planner-aggregate-schema
33 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of Embucket Snowflake query compatibility work.
Rationale for this change
Snowflake removes insignificant trailing zeros when inferring exact numeric literal types:
10.00isNUMBER(2,0),10.10isNUMBER(3,1), and0.00100isNUMBER(4,3). DataFusion currently preserves the textual scale. This affects result metadata and decimal rendering in otherwise-correct queries.What changes are included in this PR?
datafusion.sql_parser.trim_decimal_literal_trailing_zeros(defaultfalse).The default DataFusion behavior is unchanged. Rustice enables this option explicitly.
Are there any user-facing changes?
Only for applications that enable the new option.
How was this tested?
cargo test -p datafusion-sql --lib(92 passed)cargo test -p datafusion-sql --test sql_integration parse_decimals_trim_insignificant_trailing_zeroscargo check -p datafusioncargo clippy -p datafusion-common -p datafusion-sql -p datafusion --all-targets -- -D warningscargo fmt --all -- --check