Fix wildcard keys for USING outer joins - #51
Merged
osipovartem merged 1 commit intoSep 2, 2026
Conversation
osipovartem
merged commit Sep 2, 2026
cbb778b
into
expr-planner-aggregate-schema
31 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USINGjoinsRIGHT JOINand coalesce both keys forFULL JOINWhy
The raw join schema contains one key per side. Wildcard expansion previously removed the duplicate and always retained a single physical column. For a right-only row in a full outer join, that retained left key is null, so
SELECT *returned a null join key instead of the right-side value.Verification
cargo test -p datafusion-expr --lib(248 passed)cargo test -p datafusion-sql --test sql_integration(578 passed)cargo test -p datafusion --test core_integration natural_full_join_wildcard_coalesces_join_keycargo clippy -p datafusion-expr -p datafusion-sql --all-targets -- -D warningscargo clippy -p datafusion --test core_integration -- -D warnings