You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
COR-6620 : Support EpocFlex for Octave example and Handle case headset disconnected for Octave example - #253
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Unresolved reconnection bugs can silently lose stream subscriptions, while example regressions break non-Flex support and hide exit controls during recovery.
Wrap reconnect properties assignment in a conditional check for reconnectPending.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Reconnection can lose saved recovery targets or finish without restoring all streams, while hiding the example window removes normal cancellation controls during prolonged disconnections.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Reconnection can drop requested streams, restore a stale profile, and hide the only exit controls, while EEG fallback misclassifies marker columns as electrodes.
Exclude Cortex marker columns from the EEG channel fallback
octave/examples/subscribeAndPlot.m:99
The fallback excludes MARKER, but Cortex EEG columns use MARKER_HARDWARE and MARKERS (see python/sub_data.py:126 and python/cortex.py:742). When the fallback encounters those labels, it treats them as electrode channels; add both names to the exclusion list.
Implement logic to handle missing streams during reconnection.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Hiding the figure during disconnection removes both normal exit paths and conceals reconnect status, leaving the polling loop running indefinitely if the headset remains unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.